[GitHub] [hbase] guangxuCheng commented on a change in pull request #816: HBASE-23278 Add a table-level compaction progress display on the UI

[GitBox <gi...@apache.org>]

guangxuCheng commented on a change in pull request #816: HBASE-23278 Add a table-level compaction progress display on the UI 
URL: https://github.com/apache/hbase/pull/816#discussion_r344667673
 
 

 ##########
 File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
 ##########
 @@ -140,10 +140,10 @@ if (fqtn != null && master.isInitialized()) {
   try {
   table = master.getConnection().getTable(TableName.valueOf(fqtn));
   if (table.getDescriptor().getRegionReplication() > 1) {
-    tableHeader = "<h2>Table Regions</h2><table id=\"tableRegionTable\" class=\"tablesorter table table-striped\" style=\"table-layout: fixed; word-wrap: break-word;\"><thead><tr><th>Name</th><th>Region Server</th><th>ReadRequests</th><th>WriteRequests</th><th>StorefileSize</th><th>Num.Storefiles</th><th>MemSize</th><th>Locality</th><th>Start Key</th><th>End Key</th><th>ReplicaID</th></tr></thead>";
+    tableHeader = "<h2>Table Regions</h2><table id=\"tableRegionTable\" class=\"tablesorter table table-striped\" style=\"table-layout: fixed; word-wrap: break-word;\"><thead><tr><th>Name</th><th>Region Server</th><th>ReadRequests</th><th>WriteRequests</th><th>StorefileSize</th><th>Num.Storefiles</th><th>MemSize</th><th>Locality</th><th>Start Key</th><th>End Key</th><th>Num. Compacting Cells</th><th>Num. Compacted Cells</th><th>Remaining Cells</th><th>Compaction Progress</th><th>ReplicaID</th></tr></thead>";
 
 Review comment:
   There are too many columns in the table, which is not easy to read. Maybe we can use multiple tabs to show metrics, just like the regionserver page shows all metrics of regions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services