You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/10/20 20:47:17 UTC
[PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
kou opened a new pull request, #38379:
URL: https://github.com/apache/arrow/pull/38379
### Rationale for this change
This explicit initialization is for Valgrind and OpenSSL 1.1 will be unsupported eventually. So we can disable this explicit initialization for OpenSSL 1.1.
### What changes are included in this PR?
Disable the explicit initialization with OpenSSL 1.1.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38379:
URL: https://github.com/apache/arrow/pull/38379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1783422636
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6e6fd0a30aebee6738bb4bb703344f0c866debea.
There were 2 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-10-27 04:18:23Z](https://conbench.ursa.dev/compare/runs/7ef851a2901a47188086c78d65600901...03bb82269ec04218b7dd9676f6ff72a4/)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-01, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0653b26856bf791b8000406787c86626...0653b50477e779048000530b0da8d18f)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-02, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0653b26cf4e1750c8000b0feedbb6c35...0653b50aa0be73428000ffd58e54df5f)
The [full Conbench report](https://github.com/apache/arrow/runs/18133746973) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1778633630
https://github.com/apache/arrow/issues/38304
I'm not so familiar with OpenSSL. I go to the original issue, and find that it uses openssl 3.x when trigger the error. Is that expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1773374323
:warning: GitHub issue #38378 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1773373954
@github-actions crossbow submit centos-7-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1782127857
No objection.
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1776004780
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1776333940
cc @pitrou @wgtmac
Since we just merge a similiar patch https://github.com/apache/arrow/pull/38306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1776008545
Revision: d7be15c1f06fa4c0ef37e268b1f5e93243b49d89
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4d48908e3a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4d48908e3a)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618923045/job/17978388945)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/6618923514/job/17978390716)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618923923/job/17978392040)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/17978382938)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618920943/job/17978381725)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6618921215/job/17978382467)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/6618923251/job/17978389740)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618923741/job/17978391379)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618924217/job/17978393054)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/6618921577/job/17978383640)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/6618922617/job/17978387468)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/6618922076/job/17978385456)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6618922502/job/17978387009)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/6618922855/job/17978388417)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6618922311/job/17978386338)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1773377364
Revision: d7be15c1f06fa4c0ef37e268b1f5e93243b49d89
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f3758ce9d4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f3758ce9d4)
|Task|Status|
|----|------|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6592573493/job/17913471515)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38379:
URL: https://github.com/apache/arrow/pull/38379#issuecomment-1776249967
`test-conda-cpp-valgrind` is still green.
I'll merge this in a few days if nobody objects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org