[GitHub] [hudi] danny0405 commented on a change in pull request #3843: [HUDI-2468] Metadata table support for rolling back the first commit

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #3843:
URL: https://github.com/apache/hudi/pull/3843#discussion_r735378747



##########
File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkTable.java
##########
@@ -98,11 +99,11 @@ protected HoodieFlinkTable(HoodieWriteConfig config, HoodieEngineContext context
    * @return instance of {@link HoodieTableMetadataWriter}
    */
   @Override
-  public Option<HoodieTableMetadataWriter> getMetadataWriter() {
+  public <T extends SpecificRecordBase> Option<HoodieTableMetadataWriter> getMetadataWriter(Option<T> actionMetadata) {
     synchronized (this) {
       if (!isMetadataAvailabilityUpdated) {
-        // this code assumes that if metadata availability is updated once it will not change. please revisit this logic if that's not the case.
-        // this is done to avoid repeated calls to fs.exists().
+        // This code assumes that if metadata availability is updated once it will not change.

Review comment:
       Where does the passed in `actionMetadata` used ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org