You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Shane Isbell <sh...@gmail.com> on 2009/02/26 19:56:58 UTC
Re: svn commit: r748226 - in /maven/components/trunk/maven-project/src/main/java/org/apache/maven:
profiles/ProfilesConversionUtils.java profiles/build/DefaultProfileAdvisor.java
profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
This is permanent. From my understanding, profiles.xml is almost never used,
so it's not really worth the added complexity of keeping it.
On Thu, Feb 26, 2009 at 10:35 AM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:
> Hi Shane,
>
> Author: sisbell
>> Date: Thu Feb 26 17:46:01 2009
>> New Revision: 748226
>>
>> URL: http://svn.apache.org/viewvc?rev=748226&view=rev
>> Log:
>> Removed support for profiles.xml
>>
>
> Will this be re-instantiated later or is this a permanent difference
> between 2.x and 3.x? In the latter case, shouldn't we create JIRAs for this
> and similar changes (like r747652) to have the breaking changes visible in
> the release notes somehow? Otherwise I imagine we get some more bug reports
> from unaware users.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r748226 - in /maven/components/trunk/maven-project/src/main/java/org/apache/maven: profiles/ProfilesConversionUtils.java profiles/build/DefaultProfileAdvisor.java profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
Posted by Brett Porter <br...@apache.org>.
On 27/02/2009, at 5:56 AM, Shane Isbell wrote:
> This is permanent. From my understanding, profiles.xml is almost
> never used,
> so it's not really worth the added complexity of keeping it.
I'm not entirely sure that's correct. There are a number of issues
filed in JIRA related to it (one is in the top 20, though that only
required 17 votes), and that's just some proportion of the people that
are using it.
I think there are probably alternatives (Eg, substituting values with
properties and setting them in settings.xml), but perhaps surveying
the users on the impact of this to their builds would be prudent?
Cheers,
Brett
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: svn commit: r748226 - in
/maven/components/trunk/maven-project/src/main/java/org/apache/maven:
profiles/ProfilesConversionUtils.java
profiles/build/DefaultProfileAdvisor.java
profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
Posted by Jamie Whitehouse <ba...@genesyslab.com>.
Not that I have much of a voice but as a user of profiles.xml to keep
local project settings separate from my global settings I'd really like
a reminder of this when I upgrade.
-----Original Message-----
From: Brian E. Fox <br...@reply.infinity.nu>
Reply-to: "Maven Developers List" <de...@maven.apache.org>
To: Maven Developers List <de...@maven.apache.org>
Subject: RE: svn commit: r748226 -
in /maven/components/trunk/maven-project/src/main/java/org/apache/maven:
profiles/ProfilesConversionUtils.java
profiles/build/DefaultProfileAdvisor.java
profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
Date: Thu, 26 Feb 2009 14:44:03 -0500
That doesn't negate the need for an issue and some tracking of these
changes.
-----Original Message-----
From: Shane Isbell [mailto:shane.isbell@gmail.com]
Sent: Thursday, February 26, 2009 1:57 PM
To: Maven Developers List
Subject: Re: svn commit: r748226 - in
/maven/components/trunk/maven-project/src/main/java/org/apache/maven:
profiles/ProfilesConversionUtils.java
profiles/build/DefaultProfileAdvisor.java
profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
This is permanent. From my understanding, profiles.xml is almost never
used,
so it's not really worth the added complexity of keeping it.
On Thu, Feb 26, 2009 at 10:35 AM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:
> Hi Shane,
>
> Author: sisbell
>> Date: Thu Feb 26 17:46:01 2009
>> New Revision: 748226
>>
>> URL: http://svn.apache.org/viewvc?rev=748226&view=rev
>> Log:
>> Removed support for profiles.xml
>>
>
> Will this be re-instantiated later or is this a permanent difference
> between 2.x and 3.x? In the latter case, shouldn't we create JIRAs for
this
> and similar changes (like r747652) to have the breaking changes
visible in
> the release notes somehow? Otherwise I imagine we get some more bug
reports
> from unaware users.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
-------------------------------------------------------------------------------------------------------------------
CONFIDENTIALITY NOTICE: This e-mail and any files attached may contain confidential and proprietary information of Alcatel-Lucent and/or its affiliated entities. Access by the intended recipient only is authorized. Any liability arising from any party acting, or refraining from acting, on any information contained in this e-mail is hereby excluded. If you are not the intended recipient, please notify the sender immediately, destroy the original transmission and its attachments and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Copyright in this e-mail and any attachments belongs to Alcatel-Lucent and/or its affiliated entities.
RE: svn commit: r748226 - in /maven/components/trunk/maven-project/src/main/java/org/apache/maven: profiles/ProfilesConversionUtils.java profiles/build/DefaultProfileAdvisor.java profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
That doesn't negate the need for an issue and some tracking of these
changes.
-----Original Message-----
From: Shane Isbell [mailto:shane.isbell@gmail.com]
Sent: Thursday, February 26, 2009 1:57 PM
To: Maven Developers List
Subject: Re: svn commit: r748226 - in
/maven/components/trunk/maven-project/src/main/java/org/apache/maven:
profiles/ProfilesConversionUtils.java
profiles/build/DefaultProfileAdvisor.java
profiles/build/ProfileAdvisor.java project/DefaultMavenProjectBuilder.j
This is permanent. From my understanding, profiles.xml is almost never
used,
so it's not really worth the added complexity of keeping it.
On Thu, Feb 26, 2009 at 10:35 AM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:
> Hi Shane,
>
> Author: sisbell
>> Date: Thu Feb 26 17:46:01 2009
>> New Revision: 748226
>>
>> URL: http://svn.apache.org/viewvc?rev=748226&view=rev
>> Log:
>> Removed support for profiles.xml
>>
>
> Will this be re-instantiated later or is this a permanent difference
> between 2.x and 3.x? In the latter case, shouldn't we create JIRAs for
this
> and similar changes (like r747652) to have the breaking changes
visible in
> the release notes somehow? Otherwise I imagine we get some more bug
reports
> from unaware users.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org