You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2006/11/08 16:20:54 UTC

[jira] Created: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
-----------------------------------------------------

                 Key: DERBY-2054
                 URL: http://issues.apache.org/jira/browse/DERBY-2054
             Project: Derby
          Issue Type: Test
          Components: Test
    Affects Versions: 10.3.0.0
            Reporter: Kristian Waagan
         Assigned To: Kristian Waagan
            Priority: Minor


The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
I see ...

Now, I think it is needed to update testing/README.htm .
http://svn.apache.org/repos/asf/db/derby/code/trunk/java/testing/README.htm

Anyway, I will try again.

Best regards.

Myrna van Lunteren wrote:

> On 11/12/06, Tomohito Nakayama (JIRA) <ji...@apache.org> wrote:
>
>>    [ 
>> http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12449142 
>> ]
>>
>> Tomohito Nakayama commented on DERBY-2054:
>> ------------------------------------------
>>
>> I think this may be very very basic question ...
>>
>> I executed derbyall suite with this patch.
>> But could not found the name of this test in derbyall_pass.txt (nor 
>> derbyall_fail.txt nor derbyall_skip.txt) ...
>>
>> Is newly created test system executed in derbyall suite ...?
>>
> No, it is not. Dan asked if it was ok to run separate, see:
> http://www.mail-archive.com/derby-dev@db.apache.org/msg31229.html
>
> It was then further worked out in
> http://issues.apache.org/jira/browse/DERBY-1952
>
> You need to run a junit test runner to execute the junit tests,
> separately from the 'old' test harness.
> See http://wiki.apache.org/db-derby/DerbyJUnitTesting
>
> There's also an ant junitreport target you could try out, see
> http://issues.apache.org/jira/browse/DERBY-2006
>
> HTH
> Myrna
>
>

-- 
/*

        Tomohito Nakayama
        tomonaka@basil.ocn.ne.jp
        tomohito@rose.zero.ad.jp
        tmnk@apache.org

        Naka
        http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/ 


Re: [jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by Myrna van Lunteren <m....@gmail.com>.
On 11/12/06, Tomohito Nakayama (JIRA) <ji...@apache.org> wrote:
>    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12449142 ]
>
> Tomohito Nakayama commented on DERBY-2054:
> ------------------------------------------
>
> I think this may be very very basic question ...
>
> I executed derbyall suite with this patch.
> But could not found the name of this test in derbyall_pass.txt (nor derbyall_fail.txt nor derbyall_skip.txt) ...
>
> Is newly created test system executed in derbyall suite ...?
>
No, it is not. Dan asked if it was ok to run separate, see:
http://www.mail-archive.com/derby-dev@db.apache.org/msg31229.html

It was then further worked out in
http://issues.apache.org/jira/browse/DERBY-1952

You need to run a junit test runner to execute the junit tests,
separately from the 'old' test harness.
See http://wiki.apache.org/db-derby/DerbyJUnitTesting

There's also an ant junitreport target you could try out, see
http://issues.apache.org/jira/browse/DERBY-2006

HTH
Myrna

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Tomohito Nakayama (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12448936 ] 
            
Tomohito Nakayama commented on DERBY-2054:
------------------------------------------

I'm not familiar with newly created test system at all.
Then this comment may be missed ...

System property of derby.debug.suicideOfLayerBStreaming is effective on code of NetworkServer.
Then System property must be set for process of NetworkServer.

Reading the code setUp(), 
I found both of code to call JDBC interface to execute sql which would be at NetworkClient and 
code to set System property of derby.debug.suicideOfLayerBStreaming in a same method.

In newly created test system, does NetworkServer and NetworkClient run on a same process ?
I remember that they are different in old test system ... 



> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Tomohito Nakayama (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12449142 ] 
            
Tomohito Nakayama commented on DERBY-2054:
------------------------------------------

I think this may be very very basic question ...

I executed derbyall suite with this patch.
But could not found the name of this test in derbyall_pass.txt (nor derbyall_fail.txt nor derbyall_skip.txt) ...

Is newly created test system executed in derbyall suite ...?

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12449035 ] 
            
Daniel John Debrunner commented on DERBY-2054:
----------------------------------------------

An alternative is that the test could be skipped if running in a separate process/machine.
Would need to see how much extra value having a particular test running with a remote server would be if there were many other tests running remote.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2054?page=all ]

Kristian Waagan updated DERBY-2054:
-----------------------------------

    Attachment: derby-2054-preview.diff

'derby-2054-preview.diff' is the first attempt at rewriting SuicideOfStreaming.
It is kind of special, since it uses a property inside a sanity manager block in the Derby code to generate an exception on the server. There is also the matter of only returning a suite with tests if Derby is built in sane mode (see the suite-method).

Please have a look at the suggested test, and read the comments in the code. The diffs of the two old files implementing this test are included for reference.

I will post another patch shortly, which will add a _Suite in the derbynet directory and fix a few other small things.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2054?page=all ]

Kristian Waagan resolved DERBY-2054.
------------------------------------

    Fix Version/s: 10.3.0.0
       Resolution: Fixed
       Derby Info:   (was: [Patch Available])

Committed 'derby-2054-1a.diff' to trunk with revision 474803.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463886 ] 

Kristian Waagan commented on DERBY-2054:
----------------------------------------

Committed 'derby-2054-1b.diff' with revision 495213, which calls super.tearDown().
I can't see any authentication failures when running suites.All (Java 1.5 and Java SE 6) anymore.
Will close the issue soon if no problems arise in the nightly tests.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: https://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-1b.diff, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12448977 ] 
            
Kristian Waagan commented on DERBY-2054:
----------------------------------------

You are correct, currently the NetworkServer and the client code run in the same process (see NetworkServerTestSetup).
 
When/if we extend the test system to allow for running the NetworkServer in a separate process (possibly on a remote host), the test must be rewritten/modified. I wrote a comment regarding this in the class JavaDoc.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Tomohito Nakayama (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12448178 ] 
            
Tomohito Nakayama commented on DERBY-2054:
------------------------------------------

Hello.

I remember OwnServerTests_app.properties which was needed only for OwnServerTests.java.
I think it also should be removed in your patch.

http://svn.apache.org/repos/asf/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/derbyNet/OwnServerTests_app.properties

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-2054:
-----------------------------------

    Attachment: derby-2054-1b.diff

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: https://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-1b.diff, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2054?page=all ]

Kristian Waagan updated DERBY-2054:
-----------------------------------

    Derby Info: [Patch Available]

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Tomohito Nakayama (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12449329 ] 
            
Tomohito Nakayama commented on DERBY-2054:
------------------------------------------

According to http://wiki.apache.org/db-derby/DerbyJUnitTesting,
I executed org.apache.derbyTesting.functionTests.suites.All and 
confirmed that SuicideOfStreamingTest was passed.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12450595 ] 
            
Daniel John Debrunner commented on DERBY-2054:
----------------------------------------------

SuicideOfStreamingTest.tearDown() does not call super.tearDown() which may be causing other later tests to fail due to the extra time needed to start the network server. However adding super.tearDown() causes authentication errors in later tests and in the tearDown method.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan closed DERBY-2054.
----------------------------------


> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: https://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-1b.diff, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12450783 ] 
            
Daniel John Debrunner commented on DERBY-2054:
----------------------------------------------

Having spent some time tracking down the network server timeouts (see DERBY-1966) I think those are probably unrelated.
Can you try caling super.tearDown() and see if you get  the authentication failures?

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-2054?page=comments#action_12450774 ] 
            
Kristian Waagan commented on DERBY-2054:
----------------------------------------

Dan, could you please elaborate on the problems you see with the test?

As far as I see, the only thing that would happen if super.tearDown is called, is that a rollback is issued and the the connection is closed.
I do not understand how not doing this would affect other tests with regard of "the extra time needed to start the network server".

I think that due to the other problems I had with converting the test, I forgot to close the connection manually. This would have to be done inside a try-block, where any exceptions are ignored. This is because setting the debug property causes havoc in the communication between the client and the server. My intention was that the network server I use is to be used only for this test, since simply unsetting the debug property is not enough for it to recover.

Also, what authentication errors are you seeing?

Thanks,

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2054) Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2054?page=all ]

Kristian Waagan updated DERBY-2054:
-----------------------------------

    Attachment: derby-2054-1a.diff
                derby-2054-1a.stat

Thanks Tomohito. My patch removes several files.

'derby-2054-1a.diff' rewrites the SuicideOfStreaming tests to a JUnit test and: Deletes files no longer needed, adds SqlException and ByteArrayCombinerStreamTest to derbynet/_Suite, update suite files for the old harness, rewrite DDMWriter so that it requires the debug property to be true (not only set).

Patch ready for review/commit.

> Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test
> -----------------------------------------------------
>
>                 Key: DERBY-2054
>                 URL: http://issues.apache.org/jira/browse/DERBY-2054
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2054-1a.diff, derby-2054-1a.stat, derby-2054-preview.diff
>
>
> The test 'derbynet/SuicideOfStreaming' should be rewritten to a JUnit test more in line with our newly created test system.
> It is one of the last tests still being run from the deprecated 'tests/junitTests/' directory, through a wrapper class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira