Re: [PR] fix(timeseries): correct x-axis ordering for string and numeric-like dimensions [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #36214:
URL: https://github.com/apache/superset/pull/36214#issuecomment-5039553908

   @YousufFFFF this is now conflicting with `master`, needs a rebase. I'll see if I can help with that.
   
   The bigger open question from before still stands, though: sorting each series' `data` array doesn't reorder the category axis itself, and without an explicit `axis.data`, ECharts builds category order from first-encounter across all series. With multiple series that could still skip categories the way #35853 describes. Did you get a chance to check that against a multi-series repro?
   
   Also still `any` all the way through, which runs against where we're headed with typing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org