You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/09/25 08:14:33 UTC
[PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580
The fuzz targets only report a slow input once it passes libFuzzer's timeout, so a path whose cost doubles with each nesting level stays invisible until it takes tens of seconds. The unary minus printing blowup fixed in #2541 and #2577 surfaced that way, through 23 s and 150 s timeouts in a downstream canonicalizer, while inputs costing 40 ms to print went unreported.
`fuzz_stage_cost` times tokenizing, parsing and printing the same input with every dialect and fails when a stage takes more than 50 times as long as the stage before it, once that stage passes 10 ms. Both times come from the same process at the same moment, so sanitizer and machine load slow them alike, and a breach is reported only if the fastest of three repeat runs still breaches.
Starting from the existing seeds, it found the unary minus blowup on `main` in under nine minutes as `SELECT CeaSE------…`, since MySQL starts a comment at `--` only when whitespace follows, and a 20-sign version reports 276 ms to print against 0.4 ms to parse. With that fix applied, ten minutes and 650k runs reported nothing.
Until #2541 and #2577 land, the ClusterFuzzLite run on this PR can fail on that known blowup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580#issuecomment-5830418807
Odd, I would have expected for this to go red.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580#issuecomment-5959141705
Thanks @LucaCappelletti94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580#issuecomment-5829223042
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.02%. Comparing base ([`393c2c3`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/393c2c3bd148dfc268339eb58fd821d631302ee4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a4b0838`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/a4b0838c7070a25c90649d1fdf5d8ea584332c16?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2580 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 42 42
Lines 33436 33436
Branches 33436 33436
=======================================
Hits 27090 27090
Misses 2789 2789
Partials 3557 3557
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2580?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add a fuzz target that flags superlinear parsing and printing [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2580:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2580#issuecomment-5954874738
@alamb @iffyio I would proceed to merge this if that is okay with you as to prevent to merge superlinear PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org