You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/08/08 04:00:34 UTC
Review Request 68266: Added a benchmark for Mesos containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gilbert Song.
Repository: mesos
Description
-------
The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.
Diffs
-----
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/1/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
Thanks,
Jie Yu
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/#review207023
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68266]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 8, 2018, 11:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68266/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2018, 11:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The benchmark uses the standalone container agent API so that it avoids
> the irrelevant agent code paths.
>
>
> Diffs
> -----
>
> src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
> src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68266/diff/5/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/#review207008
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68266']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2119/mesos-review-68266
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2119/mesos-review-68266/logs/mesos-tests.log):
```
W0809 00:23:54.741313 12804 slave.cpp:3914] Ignoring shutdown framework e7dc9a5a-1557-40e0-8702-49b74a1265e8-0000 because it is terminating
I0809 00:23:54.741313 14256 master.cpp:10974] Removing task 384cae81-df32-4ae5-868f-61f750220f73 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework e7dc9a5a-1557-40e0-8702-49b74a1265e8-0000 on agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0 at slave(462)@192.10.1.6:52489 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0809 00:23:54.745301 14256 master.cpp:1251] Agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0 at slave(462)@192.10.1.6:52489 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0809 00:23:54.745301 14256 master.cpp:3267] Disconnecting agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0 at slave(462)@192.10.1.6:52489 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0809 00:23:54.745301 14256 master.cpp:3286] Deactivating agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0 at slave(462)@192.10.1.6:52489 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0809 00:23:54.746338 6228 hierarchical.cpp:359] Removed framework e7dc9a5a-1557-40e0-8702-49b74a1265e8-0000
I0809 00:23:54.746338 6228 hierarchical.cpp:795] Agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0 deactivated
I0809 00:23:54.746338 16056 containerizer.cpp:2407] Destroying container dfcbd8b8-c0e5-435e-9b50-fdd2d111eccc in RUNNING state
I0809 00:23:54.746338 16056 containerizer.cpp:3021] Transitioning the state of container dfcbd8b8-c0e5-435e-9b50-fdd2d111eccc from RUNNING to DESTROYING
I0809 00:23:54.746338 16056 launcher.cpp:155] Asked to destroy container dfcbd8[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (692 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (712 ms total)
[----------] Global test environment tear-down
[==========] 1031 tests from 101 test cases ran. (533937 ms total)
[ PASSED ] 1027 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] SlaveTest.StatisticsEndpointAuthentication
[ FAILED ] Endpoint/SlaveEndpointTest.AuthorizedRequest/1, where GetParam() = "monitor/statistics.json"
[ FAILED ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1, where GetParam() = "monitor/statistics.json"
[ FAILED ] Endpoint/SlaveEndpointTest.NoAuthorizer/1, where GetParam() = "monitor/statistics.json"
4 FAILED TESTS
YOU HAVE 222 DISABLED TESTS
b8-c0e5-435e-9b50-fdd2d111eccc
I0809 00:23:54.799322 12804 containerizer.cpp:2860] Container dfcbd8b8-c0e5-435e-9b50-fdd2d111eccc has exited
I0809 00:23:54.829316 16172 master.cpp:1093] Master terminating
I0809 00:23:54.831326 9580 hierarchical.cpp:637] Removed agent e7dc9a5a-1557-40e0-8702-49b74a1265e8-S0
I0809 00:23:55.119323 11288 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 8, 2018, 11:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68266/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2018, 11:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The benchmark uses the standalone container agent API so that it avoids
> the irrelevant agent code paths.
>
>
> Diffs
> -----
>
> src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
> src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68266/diff/5/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
-----------------------------------------------------------
(Updated Aug. 8, 2018, 11:19 p.m.)
Review request for mesos, Benjamin Mahler and Gilbert Song.
Repository: mesos
Description
-------
The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.
Diffs (updated)
-----
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/5/
Changes: https://reviews.apache.org/r/68266/diff/4-5/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
Thanks,
Jie Yu
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/#review206970
-----------------------------------------------------------
PASS: Mesos patch 68266 was successfully built and tested.
Reviews applied: `['68266']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2118/mesos-review-68266
- Mesos Reviewbot Windows
On Aug. 8, 2018, 4:59 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68266/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2018, 4:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The benchmark uses the standalone container agent API so that it avoids
> the irrelevant agent code paths.
>
>
> Diffs
> -----
>
> src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
> src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68266/diff/4/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
-----------------------------------------------------------
(Updated Aug. 8, 2018, 4:59 a.m.)
Review request for mesos, Benjamin Mahler and Gilbert Song.
Repository: mesos
Description
-------
The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.
Diffs (updated)
-----
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/4/
Changes: https://reviews.apache.org/r/68266/diff/3-4/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
Thanks,
Jie Yu
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
-----------------------------------------------------------
(Updated Aug. 8, 2018, 4:33 a.m.)
Review request for mesos, Benjamin Mahler and Gilbert Song.
Repository: mesos
Description
-------
The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.
Diffs (updated)
-----
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/3/
Changes: https://reviews.apache.org/r/68266/diff/2-3/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
Thanks,
Jie Yu
Re: Review Request 68266: Added a benchmark for Mesos containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
-----------------------------------------------------------
(Updated Aug. 8, 2018, 4:26 a.m.)
Review request for mesos, Benjamin Mahler and Gilbert Song.
Repository: mesos
Description
-------
The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.
Diffs (updated)
-----
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/2/
Changes: https://reviews.apache.org/r/68266/diff/1-2/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* --benchmark
Thanks,
Jie Yu