You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/12/29 09:05:55 UTC
[GitHub] [incubator-echarts] Ovilia opened a new pull request #13898: fix(bar-race): fix when no oldOrder
Ovilia opened a new pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
If calling `setOption` with `notMerge`, there is no `oldOrder` so accessing `oldOrder[i]` get error. This PR fixes this problem.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
Call `setOption` with `realtimeSort` and then call `setOption` with `notMerge` as `true`.
### After: How is it fixed in this PR?
Checking `oldOrder` before accessing `oldOrder[i]`.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13898: fix(bar-race): fix when no oldOrder
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898#issuecomment-752003786
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13898: fix(bar-race): fix when no oldOrder
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] nelsonbbarriento23 commented on pull request #13898: fix(bar-race): fix when no oldOrder
Posted by GitBox <gi...@apache.org>.
nelsonbbarriento23 commented on pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898#issuecomment-752004096
Ia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13898: fix(bar-race): fix when no oldOrder
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898#issuecomment-753785551
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] nelsonbbarriento23 removed a comment on pull request #13898: fix(bar-race): fix when no oldOrder
Posted by GitBox <gi...@apache.org>.
nelsonbbarriento23 removed a comment on pull request #13898:
URL: https://github.com/apache/incubator-echarts/pull/13898#issuecomment-752004096
Ia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org