You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2022/07/14 19:22:12 UTC

[GitHub] [samza] kw2542 opened a new pull request, #1617: SAMZA-2753: Consolidate Clocks

kw2542 opened a new pull request, #1617:
URL: https://github.com/apache/samza/pull/1617

   Issues: Improve the usability of clock related interface/classes
   
   Changes:
   1. Move SystemClock from scala to java
   2. Enrich SystemHighResolutionClock for ease of use
   3. Add comments to Clock
   
   API Changes: N/A
   Upgrade Instructions: N/A
   Usage Instructions: N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1617: SAMZA-2753: Consolidate Clocks

Posted by GitBox <gi...@apache.org>.
mynameborat commented on PR #1617:
URL: https://github.com/apache/samza/pull/1617#issuecomment-1184827985

   Why are we making `SystemHighResolutionClock` singleton? It is unclear what the motivation is from the RB description nor the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] kw2542 merged pull request #1617: SAMZA-2753: Consolidate Clocks

Posted by GitBox <gi...@apache.org>.
kw2542 merged PR #1617:
URL: https://github.com/apache/samza/pull/1617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] kw2542 commented on pull request #1617: SAMZA-2753: Consolidate Clocks

Posted by GitBox <gi...@apache.org>.
kw2542 commented on PR #1617:
URL: https://github.com/apache/samza/pull/1617#issuecomment-1187818550

   > > 
   > 
   > Sounds good. Please fix the checkstyle issues before committing the PR.
   
   The latest diff has checkstyle fixed, can you take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1617: SAMZA-2753: Consolidate Clocks

Posted by GitBox <gi...@apache.org>.
mynameborat commented on PR #1617:
URL: https://github.com/apache/samza/pull/1617#issuecomment-1187810920

   > 
   
   Sounds good. Please fix the checkstyle issues before committing the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] kw2542 commented on pull request #1617: SAMZA-2753: Consolidate Clocks

Posted by GitBox <gi...@apache.org>.
kw2542 commented on PR #1617:
URL: https://github.com/apache/samza/pull/1617#issuecomment-1184899123

   > Why are we making `SystemHighResolutionClock` singleton? It is unclear what the motivation is from the RB description nor the code.
   
   Two rationales behind:
   1. To be consistent with SystemClock 
   2. The implementation of returning `System.nanoTime` has nothing to do with instance of `SystemHighResolutionClock`, therefore a singleton pattern is more straightforward.
   What do you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org