You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/24 08:15:17 UTC

[GitHub] [druid] aditya-r-m opened a new pull request #9396: fix cursor position after function autocomplete

aditya-r-m opened a new pull request #9396: fix cursor position after function autocomplete
URL: https://github.com/apache/druid/pull/9396
 
 
   Fixes #9395.
   
   ### Description
   
   Removed unnecessary editor.goToLine call after function name is inserted into the UI of SQL editor via auto-complete.
   The small patch fixes the issue of cursor moving inside the inserted word after insertion.
   
   This PR has:
   - [x] been self-reviewed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky commented on issue #9396: fix cursor position after function autocomplete

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9396: fix cursor position after function autocomplete
URL: https://github.com/apache/druid/pull/9396#issuecomment-591551728
 
 
   Great! thank you for fixing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky merged pull request #9396: fix cursor position after function autocomplete

Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #9396: fix cursor position after function autocomplete
URL: https://github.com/apache/druid/pull/9396
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org