You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/08/15 21:26:20 UTC
Review Request: Bumping up timeouts for flaky log_tests.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Description
-------
I get some flakiness on my local machine, so bumping up the timeouts.
Diffs
-----
src/tests/log_tests.cpp 9397da4
Diff: https://reviews.apache.org/r/6643/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Bumping up timeouts for flaky log_tests.cpp
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 15, 2012, 11:30 p.m., Jie Yu wrote:
> > src/tests/log_tests.cpp, line 282
> > <https://reviews.apache.org/r/6643/diff/1/?file=141061#file141061line282>
> >
> > Just curious, is it possible to use Clock::advance() or something like that to make the test more robust? (instead of relying on absolute timeout which depends on how fast your machine is).
yeah timeouts in tests are pretty evil, that is a question I'll let ben answer for these tests
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/#review10374
-----------------------------------------------------------
On Aug. 15, 2012, 7:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6643/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2012, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Description
> -------
>
> I get some flakiness on my local machine, so bumping up the timeouts.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 9397da4
>
> Diff: https://reviews.apache.org/r/6643/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Bumping up timeouts for flaky log_tests.cpp
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 15, 2012, 11:30 p.m., Jie Yu wrote:
> > src/tests/log_tests.cpp, line 282
> > <https://reviews.apache.org/r/6643/diff/1/?file=141061#file141061line282>
> >
> > Just curious, is it possible to use Clock::advance() or something like that to make the test more robust? (instead of relying on absolute timeout which depends on how fast your machine is).
>
> Ben Mahler wrote:
> yeah timeouts in tests are pretty evil, that is a question I'll let ben answer for these tests
We usually use Clock::advance when we have a test which actually needs to see that much time elapse (e.g., framework failover). These timeouts are a slightly different beast (more like WAIT_UNTIL has an internal 2 second timeout). Like WAIT_UNTIL, waiting the timeout value *usually* means something has gone seriously wrong.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/#review10374
-----------------------------------------------------------
On Aug. 15, 2012, 7:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6643/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2012, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Description
> -------
>
> I get some flakiness on my local machine, so bumping up the timeouts.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 9397da4
>
> Diff: https://reviews.apache.org/r/6643/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Bumping up timeouts for flaky log_tests.cpp
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/#review10374
-----------------------------------------------------------
src/tests/log_tests.cpp
<https://reviews.apache.org/r/6643/#comment22072>
Just curious, is it possible to use Clock::advance() or something like that to make the test more robust? (instead of relying on absolute timeout which depends on how fast your machine is).
- Jie Yu
On Aug. 15, 2012, 7:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6643/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2012, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Description
> -------
>
> I get some flakiness on my local machine, so bumping up the timeouts.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 9397da4
>
> Diff: https://reviews.apache.org/r/6643/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Bumping up timeouts for flaky log_tests.cpp
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/#review10411
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 15, 2012, 7:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6643/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2012, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Description
> -------
>
> I get some flakiness on my local machine, so bumping up the timeouts.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 9397da4
>
> Diff: https://reviews.apache.org/r/6643/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Bumping up timeouts for flaky log_tests.cpp
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6643/
-----------------------------------------------------------
(Updated Aug. 15, 2012, 7:26 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Description
-------
I get some flakiness on my local machine, so bumping up the timeouts.
Diffs
-----
src/tests/log_tests.cpp 9397da4
Diff: https://reviews.apache.org/r/6643/diff/
Testing
-------
make check
Thanks,
Ben Mahler