You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/03/31 20:29:11 UTC

[PR] Disable failing arrow_writer benchmark [arrow-rs]

alamb opened a new pull request, #9638:
URL: https://github.com/apache/arrow-rs/pull/9638

   # Which issue does this PR close?
   
   - Part of https://github.com/apache/arrow-rs/issues/9637
   # Rationale for this change
   
   I can't benchmark the arrow-writer changes in https://github.com/apache/arrow-rs/pull/9447 due to hitting a panic:
   - https://github.com/apache/arrow-rs/issues/9637
   
   # What changes are included in this PR?
   
   Temporarily disable the cdc benchmarks until the underlying bug is fixed
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable failing arrow_writer benchmark [arrow-rs]

Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #9638:
URL: https://github.com/apache/arrow-rs/pull/9638#discussion_r3018726927


##########
parquet/benches/arrow_writer.rs:
##########
@@ -420,10 +420,13 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
         .build();
     props.push(("zstd_parquet_2", prop));
 
+    // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed

Review Comment:
   Seems like a comment only change, do I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable failing arrow_writer benchmark [arrow-rs]

Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #9638:
URL: https://github.com/apache/arrow-rs/pull/9638#discussion_r3018733020


##########
parquet/benches/arrow_writer.rs:
##########
@@ -420,10 +420,13 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
         .build();
     props.push(("zstd_parquet_2", prop));
 
+    // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed

Review Comment:
   Or just GH's syntax highligthing is fooling me?
   
   <img width="1391" height="176" alt="Image" src="https://github.com/user-attachments/assets/d562f94f-8d5e-4f75-9f34-dc21974253a3" />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable failing arrow_writer benchmark [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9638:
URL: https://github.com/apache/arrow-rs/pull/9638#discussion_r3021311047


##########
parquet/benches/arrow_writer.rs:
##########
@@ -420,10 +420,13 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
         .build();
     props.push(("zstd_parquet_2", prop));
 
+    // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed

Review Comment:
   I will switch to `//` comments to make this clearer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable failing arrow_writer benchmark [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9638:
URL: https://github.com/apache/arrow-rs/pull/9638


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable failing arrow_writer benchmark [arrow-rs]

Posted by "HippoBaro (via GitHub)" <gi...@apache.org>.
HippoBaro commented on code in PR #9638:
URL: https://github.com/apache/arrow-rs/pull/9638#discussion_r3019473660


##########
parquet/benches/arrow_writer.rs:
##########
@@ -420,10 +420,13 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
         .build();
     props.push(("zstd_parquet_2", prop));
 
+    // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed

Review Comment:
   It's creating a comment block which encloses the benchmark definition, effectively disabling it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org