[GitHub] carryxyh closed pull request #2465: typo in junit: simle -> simple

[GitBox <gi...@apache.org>]

carryxyh closed pull request #2465: typo in junit: simle -> simple
URL: https://github.com/apache/incubator-dubbo/pull/2465
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavaCodeTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavaCodeTest.java
index 851141b63a..9d150d352f 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavaCodeTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavaCodeTest.java
@@ -34,7 +34,7 @@ String getSimpleCode() {
         return code.toString();
     }
 
-    String getSimleCodeWithoutPackage(){
+    String getSimpleCodeWithoutPackage(){
         StringBuilder code = new StringBuilder();
         code.append("public class HelloServiceImpl" + SUBFIX.getAndIncrement() + "implements org.apache.dubbo.common.compiler.support.HelloService.HelloService {");
         code.append("   public String sayHello() { ");
@@ -44,7 +44,7 @@ String getSimleCodeWithoutPackage(){
         return code.toString();
     }
 
-    String getSimleCodeWithSyntax(){
+    String getSimpleCodeWithSyntax(){
         StringBuilder code = new StringBuilder();
         code.append("package org.apache.dubbo.common.compiler.support;");
 
@@ -57,7 +57,7 @@ String getSimleCodeWithSyntax(){
     }
 
     // only used for javassist
-    String getSimleCodeWithSyntax0(){
+    String getSimpleCodeWithSyntax0(){
         StringBuilder code = new StringBuilder();
         code.append("package org.apache.dubbo.common.compiler.support;");
 
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavassistCompilerTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavassistCompilerTest.java
index c4c166c092..ac626ba3eb 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavassistCompilerTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavassistCompilerTest.java
@@ -39,7 +39,7 @@ public void testCompileJavaClass() throws Exception {
     @Test
     public void testCompileJavaClass0() throws Exception {
         JavassistCompiler compiler = new JavassistCompiler();
-        Class<?> clazz = compiler.compile(getSimleCodeWithoutPackage(), JavassistCompiler.class.getClassLoader());
+        Class<?> clazz = compiler.compile(getSimpleCodeWithoutPackage(), JavassistCompiler.class.getClassLoader());
         Object instance = clazz.newInstance();
         Method sayHello = instance.getClass().getMethod("sayHello");
         Assert.assertEquals("Hello world!", sayHello.invoke(instance));
@@ -48,7 +48,7 @@ public void testCompileJavaClass0() throws Exception {
     @Test(expected = IllegalStateException.class)
     public void testCompileJavaClass1() throws Exception {
         JavassistCompiler compiler = new JavassistCompiler();
-        Class<?> clazz = compiler.compile(getSimleCodeWithSyntax0(), JavassistCompiler.class.getClassLoader());
+        Class<?> clazz = compiler.compile(getSimpleCodeWithSyntax0(), JavassistCompiler.class.getClassLoader());
         Object instance = clazz.newInstance();
         Method sayHello = instance.getClass().getMethod("sayHello");
         Assert.assertEquals("Hello world!", sayHello.invoke(instance));
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JdkCompilerTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JdkCompilerTest.java
index 1d5af2b21d..dd0c3994b1 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JdkCompilerTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JdkCompilerTest.java
@@ -35,7 +35,7 @@ public void test_compileJavaClass() throws Exception {
     @Test(expected = IllegalStateException.class)
     public void test_compileJavaClass0() throws Exception {
         JdkCompiler compiler = new JdkCompiler();
-        Class<?> clazz = compiler.compile(getSimleCodeWithoutPackage(), JdkCompiler.class.getClassLoader());
+        Class<?> clazz = compiler.compile(getSimpleCodeWithoutPackage(), JdkCompiler.class.getClassLoader());
         Object instance = clazz.newInstance();
         Method sayHello = instance.getClass().getMethod("sayHello");
         Assert.assertEquals("Hello world!", sayHello.invoke(instance));
@@ -44,7 +44,7 @@ public void test_compileJavaClass0() throws Exception {
     @Test(expected = IllegalStateException.class)
     public void test_compileJavaClass1() throws Exception {
         JdkCompiler compiler = new JdkCompiler();
-        Class<?> clazz = compiler.compile(getSimleCodeWithSyntax(), JdkCompiler.class.getClassLoader());
+        Class<?> clazz = compiler.compile(getSimpleCodeWithSyntax(), JdkCompiler.class.getClassLoader());
         Object instance = clazz.newInstance();
         Method sayHello = instance.getClass().getMethod("sayHello");
         Assert.assertEquals("Hello world!", sayHello.invoke(instance));


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org