You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/02/06 21:19:51 UTC

Re: Review Request 65399: Windows: Moved "kill on close" job object flag to own function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65399/#review196733
-----------------------------------------------------------


Fix it, then Ship it!




Style nits only.


3rdparty/stout/include/stout/windows/os.hpp
Lines 766-767 (patched)
<https://reviews.apache.org/r/65399/#comment276560>

    You could move this right above the `SetInformationJobObject` call which uses it.



3rdparty/stout/include/stout/windows/os.hpp
Lines 772-773 (patched)
<https://reviews.apache.org/r/65399/#comment276556>

    Insert a newline after indented lines like this.



3rdparty/stout/include/stout/windows/os.hpp
Lines 778-781 (patched)
<https://reviews.apache.org/r/65399/#comment276561>

    4 space indent



3rdparty/stout/include/stout/windows/os.hpp
Lines 781-782 (patched)
<https://reviews.apache.org/r/65399/#comment276557>

    Newline ditto.



3rdparty/stout/include/stout/windows/os.hpp
Lines 784 (patched)
<https://reviews.apache.org/r/65399/#comment276559>

    4 space indent


- Joseph Wu


On Jan. 29, 2018, 12:34 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65399/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 12:34 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-6713
>     https://issues.apache.org/jira/browse/MESOS-6713
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of setting this flag unconditionally when we create a job
> object, this patch abstracts it to the the function
> `set_job_kill_on_close_limit(pid_t)` so that users can choose how to tie
> job object lifetimes together.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp ec935209fc1532ebe087ac20933c99eed393506d 
> 
> 
> Diff: https://reviews.apache.org/r/65399/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>