You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/23 13:55:06 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6430: Minor: remove unecessary cranelift dependency
alamb opened a new pull request, #6430:
URL: https://github.com/apache/arrow-datafusion/pull/6430
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/pull/6164
# Rationale for this change
@yjshen removed the other cranelift dependencies in https://github.com/apache/arrow-datafusion/pull/6164
This one appears to have been left over
# What changes are included in this PR?
Remove another unecessary dependency
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6430: Minor: remove unecessary cranelift dependency
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6430:
URL: https://github.com/apache/arrow-datafusion/pull/6430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6430: Minor: remove unecessary cranelift dependency
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6430:
URL: https://github.com/apache/arrow-datafusion/pull/6430#discussion_r1202382225
##########
datafusion/common/Cargo.toml:
##########
@@ -42,7 +42,6 @@ apache-avro = { version = "0.14", default-features = false, features = ["snappy"
arrow = { workspace = true }
arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
-cranelift-module = { version = "0.92.0", optional = true }
Review Comment:
since it is marked optional I don't think it is actually ever used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org