[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #8760: UI template init and add control environment variable

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #8760:
URL: https://github.com/apache/skywalking/pull/8760#discussion_r836414615



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/input/DashboardSetting.java
##########
@@ -28,13 +28,12 @@
 public class DashboardSetting {
     private String id;
     private String configuration;

Review comment:
       *SameNameButDifferent:*  The name `configuration;` refers to [java.lang.SuppressWarnings, lombok.Generated, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
   
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)

##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/input/DashboardSetting.java
##########
@@ -28,13 +28,12 @@
 public class DashboardSetting {
     private String id;

Review comment:
       *SameNameButDifferent:*  The name `id;` refers to [java.lang.SuppressWarnings, lombok.Generated, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
   
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org