You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/19 18:43:04 UTC

[jira] [Commented] (SAMZA-1298) if ZkConnect string contains extra path, it needs to be created on the ZK.

    [ https://issues.apache.org/jira/browse/SAMZA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017820#comment-16017820 ] 

ASF GitHub Bot commented on SAMZA-1298:
---------------------------------------

GitHub user sborya opened a pull request:

    https://github.com/apache/samza/pull/197

    SAMZA-1298: Create zk path.

    if ZK path contains extra path at the end, it needs to be created in ZK at first connect.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navina/samza createZkPath

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit bca00e931a4a249608908db7edd9b011e3a6129a
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-10T00:59:45Z

    used ApplicationConfig constant

commit d0fbc70ec4d1a3462a93a47b7885bc1d6be299f8
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-10T23:17:27Z

    adding first draft of the test

commit 26fba1c6e13cdb47b5ca6cb2e08419263b416758
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-10T23:49:49Z

    set shorter timeout for zk connect

commit b21a71e9d8b5b9c4c2462e85c8a7fb2c3d3f27e1
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T00:32:15Z

    Merge branch 'master' into unitTestZkUnavailable

commit c58643146c063968c7b2956aea41f625803533d4
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T16:53:50Z

    fixed fail test

commit c11eb5d2e78576e2ad61489584f5e94a8c0aca01
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T17:03:05Z

    Merge branch 'master' into unitTestZkUnavailable

commit fa46418aa27263a41c4af224e1e982aa6195e893
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T17:58:29Z

    restore deleted code

commit 57e5410fa3858bb52cc61b97fbdfa912fa5a42fd
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T18:39:35Z

    changed name of constant

commit d2a2f832b26d771483c1f35562f322199ec05adb
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T18:40:39Z

    Merge branch 'master' into unitTestHappyPath4

commit 9ddd8136f095f5ce9be708650b6604eb1eb2b402
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T18:41:53Z

    Merge branch 'unitTestZkUnavailable' into unitTestHappyPath4

commit 8f719d701f1e85e09a480501f94d407ed7f807c5
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T19:13:40Z

    cleanup

commit 8d16bbd68f430570926543d54d407c423eb0969d
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T19:23:56Z

    imports

commit 0f5691bf3094836790f530a6db25366000a85d97
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T21:04:16Z

    cleanup

commit a3d351e2206d3292bf04209c5710f38308d5e08a
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T21:05:40Z

    merge

commit 7fccf8895a63669d2e4c7cb399c95418b536ea51
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-11T23:50:05Z

    checkstyle

commit 2ae4854470ceccc14ec2a00b8f735363913972a1
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-12T00:34:02Z

    put aux methods into a separate class

commit f2053fbe40fe92a2edcf6fc6a3021eea3a0891dd
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-12T00:34:46Z

    format

commit efe13cd49bebcc287cc3c40dc12fa7e07fe360f4
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-15T18:34:24Z

    move some of the init code into @Before

commit 17e671bdcc47835794b35c555ee59e66851ee98b
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-15T20:37:05Z

    cleanup

commit ff44db4ca046f598884f829c30ec3666b478eb91
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-15T22:31:52Z

    added configs

commit b7d6ca1fde5b16aa4c2160e7f34f97acc41c0a3c
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-16T18:35:15Z

    fake update to trigger another build

commit c1923acf8d9409d3ce283e6e92315c0023c0e012
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T00:19:46Z

    review comments

commit 8512ab7419a37f1dee871ac7c3191c068aa042ed
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T00:23:49Z

    rename

commit 2b8ae529eaf3f4ed6264bd11f1751ae62f948c09
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T17:12:12Z

    Merge branch 'master' into StandAloneConfig

commit 7845d83c137a9c91813c811330972ea61dc080fa
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T21:00:39Z

    small refactoring

commit fae7283e5b91c59ece6f137c409e61b541ddeac6
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T21:49:16Z

    small refactoring

commit 7b2903105ce6f2ace86a63ac5d4f838c6b7652a1
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-17T23:32:14Z

    checkStyle

commit a32364fa08a37f8cf5a0042a883e09ebff5b5115
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-18T01:21:08Z

    checkstyle

commit 4e8337ca303458a5886a72b90fad4644e3e55659
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-19T17:23:37Z

    merge

commit eef9c548337828e56f188f0c7962c9ff3b52c010
Author: Boris Shkolnik <bo...@apache.org>
Date:   2017-05-19T18:32:32Z

    create path in ZK at start

----


> if ZkConnect string contains extra path, it needs to be created on the ZK.
> --------------------------------------------------------------------------
>
>                 Key: SAMZA-1298
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1298
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.13.0
>
>
> if connect string looks like
> host:port/zknode1/zknode2
> we need to create /zknode1/zknode2 on the zookeeper, when connected for the first time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)