[GitHub] [carbondata] zzcclp commented on a change in pull request #3213: [CARBONDATA-3380] Fix missing appName and AnalysisException bug in DirectSQLExample

[GitBox <gi...@apache.org>]

zzcclp commented on a change in pull request #3213: [CARBONDATA-3380] Fix missing appName and AnalysisException bug in DirectSQLExample
URL: https://github.com/apache/carbondata/pull/3213#discussion_r295200215
 
 

 ##########
 File path: examples/spark2/src/test/scala/org/apache/carbondata/examplesCI/RunExamples.scala
 ##########
 @@ -129,4 +129,8 @@ class RunExamples extends QueryTest with BeforeAndAfterAll {
   test("HiveExample") {
     HiveExample.exampleBody(spark, TestQueryExecutor.warehouse)
   }
+
+  test("DirectSQLExample") {
+    DirectSQLExample.main(null)
 
 Review comment:
   Please refer to 'CarbonSessionExample.exampleBody(spark)', use 'spark' created in RunExamples, don't re-create one in DirectSQLExample.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services