You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/03/03 20:24:10 UTC

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally 

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6251

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................

IMPALA-5027: make udf headers buildable externally

This fixes a number of issues that prevented building it:
* Use of C++11 features
* Use of internal headers that are only available in the Impala source
  tree

Testing:
Copied the headers and libImpalaUdf.a to /usr and confirmed I could
build impala-udf-samples (with some modifications to udf-test-harness
to use some modified arguments to the test harness).

We really need a better solution for automatically testing this, e.g.
IMPALA-5026, but I wanted to fix the known bugs first.

Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
---
M be/src/udf/uda-test-harness-impl.h
M be/src/udf/uda-test-harness.h
M be/src/udf/udf-debug.h
M be/src/udf/udf-test-harness.h
M be/src/udf/udf.h
5 files changed, 45 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6251/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1: Code-Review+1

seems like a reasonable first step, thanks for driving this

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6251/1/be/src/udf/udf.h
File be/src/udf/udf.h:

PS1, Line 33: USING_TYPE
> What's this for?
Oops - see https://gerrit.cloudera.org/#/c/6298/


-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6251/1/be/src/udf/udf.h
File be/src/udf/udf.h:

PS1, Line 33: USING_TYPE
What's this for?


-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1:

A lot of widely-used Linux distributions have default compilers that don't support C++11 or C++14.

E.g. RHEL 6 doesn't support C++11, RHEL 7 ships gcc 4.8.x, which doesn't support C++14 https://access.redhat.com/solutions/19458

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1:

Is it unreasonable to require C++11 support? I can see this becoming problematic with automatic linters, style-checkers etc.

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


IMPALA-5027: make udf headers buildable externally

This fixes a number of issues that prevented building it:
* Use of C++11 features
* Use of internal headers that are only available in the Impala source
  tree

Testing:
Copied the headers and libImpalaUdf.a to /usr and confirmed I could
build impala-udf-samples (with some modifications to udf-test-harness
to use some modified arguments to the test harness).

We really need a better solution for automatically testing this, e.g.
IMPALA-5026, but I wanted to fix the known bugs first.

Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Reviewed-on: http://gerrit.cloudera.org:8080/6251
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/udf/uda-test-harness-impl.h
M be/src/udf/uda-test-harness.h
M be/src/udf/udf-debug.h
M be/src/udf/udf-test-harness.h
M be/src/udf/udf.h
5 files changed, 45 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/339/

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5027: make udf headers buildable externally
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No