[GitHub] nswamy commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.
URL: https://github.com/apache/incubator-mxnet/pull/9169#discussion_r158401307
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -28,7 +28,7 @@
 else:
     from setuptools import setup
     from setuptools.extension import Extension
-    kwargs = {'install_requires': ['numpy', 'requests', 'graphviz'], 'zip_safe': False}
+    kwargs = {'install_requires': ['numpy<=1.13.3', 'requests==2.18.4', 'graphviz==0.8.1'], 'zip_safe': False}
 
 Review comment:
   I like the idea of making the dependency versions deterministic. However, we should be careful and diligently test and upgrade the versions with our releases, newer versions of the packages might release performance fixes, security fixes, etc., Lets add testing and upgrading dependent package version to MXNet Release checklist.  
   does the pip package builder use the setup.py from here?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services