[jira] [Commented] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630544#comment-17630544 ] 

ASF GitHub Bot commented on HADOOP-18246:
-----------------------------------------

sauraank opened a new pull request, #5120:
URL: https://github.com/apache/hadoop/pull/5120

   
   ### Description of PR
   Set the lower limit on s3a prefetching/caching block size as 1 byte. Not removed the limit as it would essentially result in infinite number of prefetching/caching request when the block size is 0 byte. 
   
   ### How was this patch tested?
   Done the integration test for it on ec2 instance. Not written a separate test as the change was trivial. Please, let me know if any other test is required.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> Remove lower limit on s3a prefetching/caching block size
> --------------------------------------------------------
>
>                 Key: HADOOP-18246
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18246
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.4.0
>            Reporter: Daniel Carl Jones
>            Assignee: Ankit Saurabh
>            Priority: Minor
>              Labels: pull-request-available
>
> The minimum allowed block size currently is {{PREFETCH_BLOCK_DEFAULT_SIZE}} (8MB).
> {code:java}
> this.prefetchBlockSize = intOption(
>                     conf, PREFETCH_BLOCK_SIZE_KEY, PREFETCH_BLOCK_DEFAULT_SIZE, PREFETCH_BLOCK_DEFAULT_SIZE);{code}
> [https://github.com/apache/hadoop/blob/3aa03e0eb95bbcb066144706e06509f0e0549196/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java#L487-L488]
> Why is this the case and should we lower or remove it?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org