You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/14 02:00:53 UTC
[GitHub] [hudi] ymZhao1001 opened a new pull request, #6945: [HUDI-5026] spark orc reader
ymZhao1001 opened a new pull request, #6945:
URL: https://github.com/apache/hudi/pull/6945
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-5026] spark orc reader [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #6945:
URL: https://github.com/apache/hudi/pull/6945#issuecomment-1747377815
@ymZhao1001 : Can you resolve conflicts and add ORC test case. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6945: [HUDI-5026] spark orc reader
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6945:
URL: https://github.com/apache/hudi/pull/6945#issuecomment-1278410128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12195",
"triggerID" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f802e2c5e56b1072bfc1c64792a11283473679e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12195)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a diff in pull request #6945: [HUDI-5026] spark orc reader
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on code in PR #6945:
URL: https://github.com/apache/hudi/pull/6945#discussion_r1145714301
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -571,6 +568,20 @@ abstract class HoodieBaseRelation(val sqlContext: SQLContext,
val readerSchema = StructType(requiredDataSchema.structTypeSchema.fields ++ partitionSchema.fields)
(parquetReader, readerSchema)
+ case HoodieFileFormat.ORC =>
Review Comment:
@ymZhao1001 : Can you add a testcase to showcase ORC reader working successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6945: [HUDI-5026] spark orc reader
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6945:
URL: https://github.com/apache/hudi/pull/6945#issuecomment-1278375918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f802e2c5e56b1072bfc1c64792a11283473679e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6945: [HUDI-5026] spark orc reader
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6945:
URL: https://github.com/apache/hudi/pull/6945#issuecomment-1278505710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12195",
"triggerID" : "2f802e2c5e56b1072bfc1c64792a11283473679e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f802e2c5e56b1072bfc1c64792a11283473679e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12195)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org