[GitHub] [drill] paul-rogers commented on a change in pull request #2028: DRILL-7643: Fix issues with using columns with the same name as a reserved keyword

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2028: DRILL-7643: Fix issues with using columns with the same name as a reserved keyword
URL: https://github.com/apache/drill/pull/2028#discussion_r394683080
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordCollector.java
 ##########
 @@ -318,36 +319,39 @@ public MetastoreRecordCollector(Metastore metastore, FilterEvaluator filterEvalu
      * @param schemaPath schema name
      * @param table table instance
      * @param schema table or column schema
-     * @param parentColumnName parent column name if any
+     * @param parentColumnNames list of parent column names if any
      * @param columnIndex column index if any
      * @param isNested indicates if column is nested
      * @return list of column records
      */
     private List<Records.Column> columns(String schemaPath,
                                          BaseTableMetadata table,
                                          TupleMetadata schema,
-                                         String parentColumnName,
+                                         List<String> parentColumnNames,
 
 Review comment:
   Should this be a list of names? Or a pointer to the parent? Seems redundant, for a name like `date[0].month` to have
   
   ```
   ([], 'date')
   (`date`, `[]`)
   (`date[]`, `month)
   ```
   
   Also, would be helpful to spell out what the names include. Am I right in the above examples? Are the array brackets included?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services