You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/17 22:15:26 UTC

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5537: update service category header rewrite logic

rob05c commented on a change in pull request #5537:
URL: https://github.com/apache/trafficcontrol/pull/5537#discussion_r577982800



##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -35,7 +35,7 @@ const HeaderRewritePrefix = "hdr_rw_"
 const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
 const LineCommentHeaderRewriteDotConfig = LineCommentHash
 
-const ServiceCategoryHeader = "CDN-SVC"
+const ServiceCategoryHeader = "X-CDN-SVC"

Review comment:
       Why `X-`? 
   
   The IETF has asked people to stop prefixing headers with `X-` because it makes it hard to remove in a standard later when they become common: https://tools.ietf.org/html/rfc6648




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org