You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/19 18:42:24 UTC
[GitHub] [accumulo-website] dlmarion opened a new pull request, #351: Add SVN instructions for updating the KEYS file
dlmarion opened a new pull request, #351:
URL: https://github.com/apache/accumulo-website/pull/351
Closes #350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] dlmarion merged pull request #351: Add SVN instructions for updating the KEYS file
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #351:
URL: https://github.com/apache/accumulo-website/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a diff in pull request #351: Add SVN instructions for updating the KEYS file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #351:
URL: https://github.com/apache/accumulo-website/pull/351#discussion_r1001000003
##########
contributor/making-release.md:
##########
@@ -20,7 +20,19 @@ Follow these steps to make a release of Apache Accumulo.
There are number of things that are required before attempting to build a release.
1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via .gnupg/gpg-agent.conf) to ensure that the agent doesn't require re-authentication mid-build, as it will cause things to fail. For example, you can add `default-cache-ttl 6000` to increase the timeout from the default of 10 minutes to over an hour. If you do not have a GPG key, reference the very thorough [ASF release signing documentation][1].
-2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more below).
+2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more information below about the SVN repository). You can use something similar to the instructions below for updating the KEYS file:
+ ```
+ # install git-svn
+ sudo yum install -y git-svn
+ # clone the SVN repo into the directory accumulo-dist-gitsvn
+ git svn clone https://dist.apache.org/repos/dist/release/accumulo accumulo-dist-gitsvn
+ cd accumulo-dist-gitsvn
+ # make changes to KEYS file, then commit the changes locally
+ git add KEYS
+ git commit
+ # push the changes to the remote SVN repo
+ git svn dcommit --username=<ASF_Username>
+ ```
Review Comment:
I think mine is a simpler example, as a bare minimum. But, I don't want our doc to be bloated with training people to be competent with tools that we aren't responsible for (those tools' own docs are best for that). So, if you think yours are better for most of us, go with that one. I'd rather not have two, because then where does it end? Should we provide instructions with TortoiseSVN, eSvn, etc.? Best to stick with one. I think the native svn CLI is the best example of bare minimum functionality, but more of our devs are used to git. Then again, git-svn is a whole different beast on top of git. So, I'll leave it to your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a diff in pull request #351: Add SVN instructions for updating the KEYS file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #351:
URL: https://github.com/apache/accumulo-website/pull/351#discussion_r999912223
##########
contributor/making-release.md:
##########
@@ -20,7 +20,19 @@ Follow these steps to make a release of Apache Accumulo.
There are number of things that are required before attempting to build a release.
1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via .gnupg/gpg-agent.conf) to ensure that the agent doesn't require re-authentication mid-build, as it will cause things to fail. For example, you can add `default-cache-ttl 6000` to increase the timeout from the default of 10 minutes to over an hour. If you do not have a GPG key, reference the very thorough [ASF release signing documentation][1].
-2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more below).
+2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more information below about the SVN repository). You can use something similar to the instructions below for updating the KEYS file:
+ ```
+ # install git-svn
+ sudo yum install -y git-svn
+ # clone the SVN repo into the directory accumulo-dist-gitsvn
+ git svn clone https://dist.apache.org/repos/dist/release/accumulo accumulo-dist-gitsvn
+ cd accumulo-dist-gitsvn
+ # make changes to KEYS file, then commit the changes locally
+ git add KEYS
+ git commit
+ # push the changes to the remote SVN repo
+ git svn dcommit --username=<ASF_Username>
+ ```
Review Comment:
I was worried that we were going to have a bunch of verbose documentation for svn, which I thought would be overwhelming and noisy. In general, I really hate adding documentation for other software/tools into our documentation, because it can quickly bloat our docs with scope creep. However, I think you did a good job of keeping it simple and to the point here.
Alternatively, using `svn` directly to edit only the KEYS file:
```bash
svn co https://dist.apache.org/repos/dist/release/accumulo --depth empty <checkoutDir>
svn up <checkoutDir>/KEYS
# edit the KEYS file
svn ci <checkoutDir>/KEYS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] dlmarion commented on a diff in pull request #351: Add SVN instructions for updating the KEYS file
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #351:
URL: https://github.com/apache/accumulo-website/pull/351#discussion_r1000975316
##########
contributor/making-release.md:
##########
@@ -20,7 +20,19 @@ Follow these steps to make a release of Apache Accumulo.
There are number of things that are required before attempting to build a release.
1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via .gnupg/gpg-agent.conf) to ensure that the agent doesn't require re-authentication mid-build, as it will cause things to fail. For example, you can add `default-cache-ttl 6000` to increase the timeout from the default of 10 minutes to over an hour. If you do not have a GPG key, reference the very thorough [ASF release signing documentation][1].
-2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more below).
+2. Once you are able to sign a release, add your gpg key to the [KEYS file][keys-file] (instructions are at the top of the file). This will require updating the SVN repository (more information below about the SVN repository). You can use something similar to the instructions below for updating the KEYS file:
+ ```
+ # install git-svn
+ sudo yum install -y git-svn
+ # clone the SVN repo into the directory accumulo-dist-gitsvn
+ git svn clone https://dist.apache.org/repos/dist/release/accumulo accumulo-dist-gitsvn
+ cd accumulo-dist-gitsvn
+ # make changes to KEYS file, then commit the changes locally
+ git add KEYS
+ git commit
+ # push the changes to the remote SVN repo
+ git svn dcommit --username=<ASF_Username>
+ ```
Review Comment:
@ctubbsii - did you want me to add your alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org