You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ab...@apache.org on 2023/08/15 08:59:58 UTC

[incubator-devlake] branch release-v0.18 updated: fix: scopes would not be listed over 50 (#5877)

This is an automated email from the ASF dual-hosted git repository.

abeizn pushed a commit to branch release-v0.18
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/release-v0.18 by this push:
     new 9b34bca62 fix: scopes would not be listed over 50 (#5877)
9b34bca62 is described below

commit 9b34bca62a49e4e268e658cd67c983b1706cd2f1
Author: Klesh Wong <zh...@merico.dev>
AuthorDate: Tue Aug 15 16:59:54 2023 +0800

    fix: scopes would not be listed over 50 (#5877)
---
 backend/helpers/pluginhelper/api/scope_db_helper.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/backend/helpers/pluginhelper/api/scope_db_helper.go b/backend/helpers/pluginhelper/api/scope_db_helper.go
index c5ba22e50..5bac5e5d8 100644
--- a/backend/helpers/pluginhelper/api/scope_db_helper.go
+++ b/backend/helpers/pluginhelper/api/scope_db_helper.go
@@ -113,9 +113,8 @@ func (s *ScopeDatabaseHelperImpl[Conn, Scope, Tr]) GetScopeAndConfig(connectionI
 }
 
 func (s *ScopeDatabaseHelperImpl[Conn, Scope, Tr]) ListScopes(input *plugin.ApiResourceInput, connectionId uint64) ([]*Scope, errors.Error) {
-	limit, offset := GetLimitOffset(input.Query, "pageSize", "page")
 	var scopes []*Scope
-	err := s.db.All(&scopes, dal.Where("connection_id = ?", connectionId), dal.Limit(limit), dal.Offset(offset))
+	err := s.db.All(&scopes, dal.Where("connection_id = ?", connectionId))
 	return scopes, err
 }