[GitHub] [rocketmq-spring] RongtongJin commented on a change in pull request #201: solve the probolem that RocketMQListener can not deserialize generic onMessage method parameter

[GitBox <gi...@apache.org>]

RongtongJin commented on a change in pull request #201: solve the probolem that RocketMQListener can not deserialize generic onMessage method parameter
URL: https://github.com/apache/rocketmq-spring/pull/201#discussion_r357004523
 
 

 ##########
 File path: rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java
 ##########
 @@ -46,6 +55,28 @@ public void onMessage(MessageExt message) {
         result = (Class) getMessageType.invoke(listenerContainer);
         assertThat(result.getName().equals(MessageExt.class.getName()));
     }
+
+    @Test
+    public void testGenericMessageType() throws Exception {
+        DefaultRocketMQListenerContainer listenerContainer = new DefaultRocketMQListenerContainer();
+        listenerContainer.setMessageConverter(new CompositeMessageConverter(Arrays.asList(new StringMessageConverter(), new MappingJackson2MessageConverter())));
+
+        Method getMessageType = DefaultRocketMQListenerContainer.class.getDeclaredMethod("getMessageType");
+        Method getMethodParameter = DefaultRocketMQListenerContainer.class.getDeclaredMethod("getMethodParameter");
+        getMessageType.setAccessible(true);
+        getMethodParameter.setAccessible(true);
+        listenerContainer.setRocketMQListener(new RocketMQListener<ArrayList<Date>>() {
+            @Override
+            public void onMessage(ArrayList<Date> message) {
+
+            }
+        });
+
+        ParameterizedType type = (ParameterizedType) getMessageType.invoke(listenerContainer);
+        assertThat(type.getRawType() == ArrayList.class);
+        MethodParameter methodParameter = ((MethodParameter) getMethodParameter.invoke(listenerContainer));
+        System.out.println(methodParameter);
 
 Review comment:
   It would be better that do not call System.out.println in test method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services