You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/28 07:42:04 UTC

[GitHub] [kafka] RivenSun2 opened a new pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

RivenSun2 opened a new pull request #11819:
URL: https://github.com/apache/kafka/pull/11819


   You can see their `toString` method in all xxx.java in `clients/src/generated/java` directory.
   For fields of type String, the `toString()` method is still called, which brings an unnecessary method call.
   example：
   AddOffsetsToTxnRequestData#toString()
   `@Override
   public String toString() {
       return "AddOffsetsToTxnRequestData("
           + "transactionalId=" + ((transactionalId == null) ? "null" : "'" + transactionalId.toString() + "'")
           + ", producerId=" + producerId
           + ", producerEpoch=" + producerEpoch
           + ", groupId=" + ((groupId == null) ? "null" : "'" + groupId.toString() + "'")
           + ")";
   } `
   
   In fact, `transactionalId` and `groupId` are already String types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1069812919


   Hi @dajac @cmccabe
   Could you help to review the PR ?
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1063741527


   Hi @dajac @cmccabe 
   Could you help to review the PR ?
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1053975616


   Hi @guozhangwang @cmccabe @dajac 
   please help to review the PR .
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

Posted by GitBox <gi...@apache.org>.
RivenSun2 edited a comment on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1053975616


   Hi @guozhangwang @cmccabe @dajac and @showuon 
   please help to review the PR .
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1060087311


   Hi @cmccabe 
   Could you help to review the PR ?
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org