[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

[GitBox <gi...@apache.org>]

eskabetxe commented on code in PR #12:
URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1053484871


##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkMigrationTest.java:
##########
@@ -77,7 +79,8 @@ public JdbcXaSinkMigrationTest(FlinkVersion readVersion) {
 
     private final FlinkVersion readVersion;
 
-    @Test
+    @TestTemplate
+    @Disabled

Review Comment:
   I have to disable this as getReadVersions return a empty list..
   This method appear to be used only manually as nothing is tested in normal execution.
   
   I try to return some FlinkVersion but resources are missing :S
   I get this error:
   `java.io.FileNotFoundException: src/test/resources/jdbc-exactly-once-sink-migration-1.16-snapshot (No such file or directory)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org