You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/14 02:23:30 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
AngersZhuuuu opened a new pull request #32155:
URL: https://github.com/apache/spark/pull/32155
### What changes were proposed in this pull request?
Add change of `DESC NAMESPACE`'s schema to migration guide
### Why are the changes needed?
Update doc
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819183843
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137315/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819241444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41904/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819226307
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137324/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819221974
**[Test build #137324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137324/testReport)** for PR 32155 at commit [`a1084e5`](https://github.com/apache/spark/commit/a1084e52b938c5f7f89c5de7aff056e1e65f7461).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819221974
**[Test build #137324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137324/testReport)** for PR 32155 at commit [`a1084e5`](https://github.com/apache/spark/commit/a1084e52b938c5f7f89c5de7aff056e1e65f7461).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819178602
**[Test build #137315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137315/testReport)** for PR 32155 at commit [`df56e74`](https://github.com/apache/spark/commit/df56e74f99566871b9522083c7e017ab2f6f95ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819198314
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819204251
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819226181
**[Test build #137324 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137324/testReport)** for PR 32155 at commit [`a1084e5`](https://github.com/apache/spark/commit/a1084e52b938c5f7f89c5de7aff056e1e65f7461).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819183148
**[Test build #137315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137315/testReport)** for PR 32155 at commit [`df56e74`](https://github.com/apache/spark/commit/df56e74f99566871b9522083c7e017ab2f6f95ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819265386
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819174098
FYI @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819226307
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137324/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819178602
**[Test build #137315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137315/testReport)** for PR 32155 at commit [`df56e74`](https://github.com/apache/spark/commit/df56e74f99566871b9522083c7e017ab2f6f95ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819241444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41904/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819183843
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137315/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32155:
URL: https://github.com/apache/spark/pull/32155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32155:
URL: https://github.com/apache/spark/pull/32155#discussion_r612930118
##########
File path: docs/sql-migration-guide.md
##########
@@ -75,6 +75,8 @@ license: |
- In Spark 3.2, `CREATE TABLE .. LIKE ..` command can not use reserved properties. You need their specific clauses to specify them, for example, `CREATE TABLE test1 LIKE test LOCATION 'some path'`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, these properties will be silently removed, for example: `TBLPROPERTIES('owner'='yao')` will have no effect. In Spark version 3.1 and below, the reserved properties can be used in `CREATE TABLE .. LIKE ..` command but have no side effects, for example, `TBLPROPERTIES('location'='/tmp')` does not change the location of the table but only create a headless property just like `'a'='b'`.
+ - In Spark 3.2, the output schema of `DESCRIBE NAMESPACE` becomes `info_name: string, info_value: string`. In Spark 3.1 or earlier, the `info_name` field was named `database_description_item` and the `info_value` field was named `database_description_value` for the builtin catalog. To restore the old schema with the builtin catalog, you can set `spark.sql.legacy.keepCommandOutputSchema` to `true`.
Review comment:
> nit: can we put the items for legacy command output schema close to each other?
Done and move `SHOW TBLPROPERTIES` close too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32155:
URL: https://github.com/apache/spark/pull/32155#discussion_r612914753
##########
File path: docs/sql-migration-guide.md
##########
@@ -75,6 +75,8 @@ license: |
- In Spark 3.2, `CREATE TABLE .. LIKE ..` command can not use reserved properties. You need their specific clauses to specify them, for example, `CREATE TABLE test1 LIKE test LOCATION 'some path'`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, these properties will be silently removed, for example: `TBLPROPERTIES('owner'='yao')` will have no effect. In Spark version 3.1 and below, the reserved properties can be used in `CREATE TABLE .. LIKE ..` command but have no side effects, for example, `TBLPROPERTIES('location'='/tmp')` does not change the location of the table but only create a headless property just like `'a'='b'`.
+ - In Spark 3.2, the output schema of `DESCRIBE NAMESPACE` becomes `info_name: string, info_value: string`. In Spark 3.1 or earlier, the `info_name` field was named `database_description_item` and the `info_value` field was named `database_description_value` for the builtin catalog. To restore the old schema with the builtin catalog, you can set `spark.sql.legacy.keepCommandOutputSchema` to `true`.
Review comment:
nit: can we put the items for legacy command output schema close to each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819236117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32155: [SPARK-34577][SQL][FOLLOWUP] Add change of `DESC NAMESPACE`'s schema to migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32155:
URL: https://github.com/apache/spark/pull/32155#issuecomment-819204251
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org