You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/09 06:27:44 UTC
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18826: [cherry-pick][branch-2.11] cherry-pick fixing can not delete namespace by force (#18307)
poorbarcode commented on code in PR #18826:
URL: https://github.com/apache/pulsar/pull/18826#discussion_r1044127200
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1178,20 +1178,28 @@ private CompletableFuture<Void> delete(boolean failIfHasSubscriptions,
return null;
});
- closeClientFuture.thenAccept(delete -> {
- CompletableFuture<Void> deleteTopicAuthenticationFuture = new CompletableFuture<>();
- brokerService.deleteTopicAuthenticationWithRetry(topic, deleteTopicAuthenticationFuture, 5);
- deleteTopicAuthenticationFuture.thenCompose(__ -> deleteSchema())
- .thenCompose(__ -> deleteTopicPolicies())
- .thenCompose(__ -> transactionBufferCleanupAndClose())
- .whenComplete((v, ex) -> {
- if (ex != null) {
- log.error("[{}] Error deleting topic", topic, ex);
- unfenceTopicToResume();
- deleteFuture.completeExceptionally(ex);
- } else {
- List<CompletableFuture<Void>> subsDeleteFutures = new ArrayList<>();
- subscriptions.forEach((sub, p) -> subsDeleteFutures.add(unsubscribe(sub)));
+ closeClientFuture.thenAccept(__ -> {
+ CompletableFuture<Void> deleteTopicAuthenticationFuture = new CompletableFuture<>();
+ brokerService.deleteTopicAuthenticationWithRetry(topic, deleteTopicAuthenticationFuture, 5);
+
+ deleteTopicAuthenticationFuture.thenCompose(ignore -> deleteSchema())
Review Comment:
Should we format the code here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org