You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/11 16:12:26 UTC
[GitHub] [spark] dilipbiswal commented on a change in pull request #24348:
[SPARK-27444][SQL] multi-select can be used in subquery
dilipbiswal commented on a change in pull request #24348: [SPARK-27444][SQL] multi-select can be used in subquery
URL: https://github.com/apache/spark/pull/24348#discussion_r274503341
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -356,14 +355,14 @@ resource
: identifier STRING
;
-insertStatement
- : (ctes)? insertInto queryTerm queryOrganization #singleInsertQuery
- | (ctes)? fromClause multiInsertQueryBody+ #multiInsertQuery
+dmlStatementNoWith
+ : insertInto queryTerm queryOrganization #singleInsertQuery
+ | fromClause multiInsertQueryBody+ #multiInsertQuery
;
queryNoWith
: queryTerm queryOrganization #noWithQuery
- | fromClause selectStatement #queryWithFrom
+ | fromClause selectStatement+ #queryWithFrom
Review comment:
@cloud-fan Okay.. sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org