You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/11 06:40:08 UTC

[GitHub] [incubator-superset] hughhhh edited a comment on issue #7485: Break line before LIMIT statement to prevent trailing comment issue

hughhhh edited a comment on issue #7485: Break line before LIMIT statement to prevent trailing comment issue
URL: https://github.com/apache/incubator-superset/pull/7485#issuecomment-491484802
 
 
   LGTM
   we could also do the `/n` append in the here:
   https://github.com/apache/incubator-superset/blob/2b3c6c5531a20d99c5d7c1020cb99ad546e36178/superset/sql_parse.py#L34

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org