You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/11/02 05:47:26 UTC
[PR] Bump all dependencies of Go and Node [skywalking-banyandb]
hanahmily opened a new pull request, #349:
URL: https://github.com/apache/skywalking-banyandb/pull/349
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump all dependencies of Go and Node [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #349:
URL: https://github.com/apache/skywalking-banyandb/pull/349#issuecomment-1790114389
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#349](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/349?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6e86aff) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/20f36438894d396982b7d6c75da3c98a4d69bd02?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (20f3643) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 38.21% 38.21%
=======================================
Files 117 117
Lines 12831 12831
=======================================
Hits 4904 4904
Misses 7445 7445
Partials 482 482
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump all dependencies of Go and Node [skywalking-banyandb]
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on code in PR #349:
URL: https://github.com/apache/skywalking-banyandb/pull/349#discussion_r1380055929
##########
banyand/query/processor_topn.go:
##########
@@ -362,13 +362,8 @@ func (naggr *postNonAggregationProcessor) Val(tagNames []string) []*measurev1.To
})
}
- slices.SortStableFunc(topNLists, func(a, b *measurev1.TopNList) bool {
- if a.GetTimestamp().GetSeconds() < b.GetTimestamp().GetSeconds() {
- return true
- } else if a.GetTimestamp().GetSeconds() == b.GetTimestamp().GetSeconds() {
- return a.GetTimestamp().GetNanos() < b.GetTimestamp().GetNanos()
- }
- return false
+ slices.SortStableFunc(topNLists, func(a, b *measurev1.TopNList) int {
+ return int(a.GetTimestamp().GetSeconds() - b.GetTimestamp().GetSeconds())
Review Comment:
I suppose we should also compare nano seconds part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump all dependencies of Go and Node [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #349:
URL: https://github.com/apache/skywalking-banyandb/pull/349#discussion_r1379624217
##########
banyand/query/processor_topn.go:
##########
@@ -362,13 +362,8 @@ func (naggr *postNonAggregationProcessor) Val(tagNames []string) []*measurev1.To
})
}
- slices.SortStableFunc(topNLists, func(a, b *measurev1.TopNList) bool {
- if a.GetTimestamp().GetSeconds() < b.GetTimestamp().GetSeconds() {
- return true
- } else if a.GetTimestamp().GetSeconds() == b.GetTimestamp().GetSeconds() {
- return a.GetTimestamp().GetNanos() < b.GetTimestamp().GetNanos()
- }
- return false
+ slices.SortStableFunc(topNLists, func(a, b *measurev1.TopNList) int {
+ return int(a.GetTimestamp().GetSeconds() - b.GetTimestamp().GetSeconds())
Review Comment:
@lujiajing1126 Please review this update. I need to modify it due to a breaking change to the function which is from `golang.org/x/exp` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump all dependencies of Go and Node [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #349:
URL: https://github.com/apache/skywalking-banyandb/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org