You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 16:25:00 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #11997: ARROW-10998: [C++] Detect URIs where a filesystem path is expected

pitrou commented on a change in pull request #11997:
URL: https://github.com/apache/arrow/pull/11997#discussion_r772501730



##########
File path: cpp/src/arrow/filesystem/gcsfs_test.cc
##########
@@ -797,6 +838,11 @@ TEST_F(GcsIntegrationTest, OpenInputStreamInfoInvalid) {
   ASSERT_RAISES(IOError, fs->OpenInputStream(info));
 }
 
+TEST_F(GcsIntegrationTest, OpenInputStreamUri) {
+  auto fs = internal::MakeGcsFileSystemForTest(TestGcsOptions());
+  ASSERT_RAISES(Invalid, fs->OpenInputStream("gcs:" + PreexistingObjectPath()));

Review comment:
       I see, thank you.
   By the way, it seems other packages have adopted the `gcs://` convention: https://gcsfs.readthedocs.io/en/latest/#integration




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org