[GitHub] jlahoda commented on a change in pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project
URL: https://github.com/apache/incubator-netbeans/pull/495#discussion_r183279387
 
 

 ##########
 File path: maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java
 ##########
 @@ -322,6 +322,10 @@ public void setValue(Union2<JavaPlatform,String> value) {
                 }
             }
         };
+        // the selected item is not set until the compile panel is shown
+        // so, invoke these methods for setting it
+        compleComboBoxUpdater.ancestorAdded(null);
+        compleComboBoxUpdater.ancestorRemoved(null);
 
 Review comment:
   A question: why is it needed to set the value here? (I.e. can't it wait until the compile panel is shown as it seems was done before?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists