You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/17 10:55:19 UTC
[GitHub] [dolphinscheduler] gaojun2048 opened a new issue #8972: [Bug] [Server] UT failed in LoggerServer
gaojun2048 opened a new issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
UT failed in LoggerServer `LoggerServerTest`.
### What you expected to happen
UT success.
### How to reproduce
fix the UT code.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1070823839
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1072174298
I have checked this issue and found the 'testRemoveTaskLog' UT method throw an exception but UT is successful on my local machine.
The method has the following functions:
1. Create a file '\tmp\remove.log'.
2. Call method 'logClientService.removeTaskLog' to delete the log.
3. Read the file and view the log.
The question is the 3rd step, the file has already been deleted so that throw a 'FileNotFoundException' and cause a logger print 'ERROR' log. I think this one is fine, it is reasonable and the UT result is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1070823839
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] gaojun2048 commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1072187396
> have checked this issue and found the 'testRemoveTaskLog' UT method throw an exception but UT is successful on my local machine. The method has the following functions:
>
> 1. Create a file '\tmp\remove.log'.
> 2. Call method 'logClientService.removeTaskLog' to delete the log.
> 3. Read the file and view the log.
> The question is the 3rd step, the file has already been deleted so that throw a 'FileNotFoundException' and cause a logger print 'ERROR' log. I think this one is fine, it is reasonable and the UT result is successful.
So, Is there a problem here? Do I need to modify it ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1072174298
I have checked this issue and found the 'testRemoveTaskLog' UT method throw an exception but UT is successful on my local machine.
The method has the following functions:
1. Create a file '\tmp\remove.log'.
2. Call method 'logClientService.removeTaskLog' to delete the log.
3. Read the file and view the log.
The question is the 3rd step, the file has already been deleted so that throw a 'FileNotFoundException' and cause a logger print 'ERROR' log. I think this one is fine, it is reasonable and the UT result is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] gaojun2048 commented on issue #8972: [Bug] [Server] UT failed in LoggerServer
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #8972:
URL: https://github.com/apache/dolphinscheduler/issues/8972#issuecomment-1072187396
> have checked this issue and found the 'testRemoveTaskLog' UT method throw an exception but UT is successful on my local machine. The method has the following functions:
>
> 1. Create a file '\tmp\remove.log'.
> 2. Call method 'logClientService.removeTaskLog' to delete the log.
> 3. Read the file and view the log.
> The question is the 3rd step, the file has already been deleted so that throw a 'FileNotFoundException' and cause a logger print 'ERROR' log. I think this one is fine, it is reasonable and the UT result is successful.
So, Is there a problem here? Do I need to modify it ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org