Re: [PR] PARQUET-2485: Be more consistent with BYTE_ARRAY types [parquet-format]

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #251:
URL: https://github.com/apache/parquet-format/pull/251#discussion_r1635669939


##########
LogicalTypes.md:
##########
@@ -59,7 +60,7 @@ Compatibility considerations are mentioned for each annotation in the correspond
 
 ### STRING
 
-`STRING` may only be used to annotate the binary primitive type and indicates
+`STRING` may only be used to annotate the BYTE_ARRAY primitive type and indicates

Review Comment:
   It seems the spec is unclear about whether or not `STRING` and `ENUM` can annotate `FIXED_LENGTH_BYTE_ARRAY`. Literally it is reasonable to annotate `FIXED_LENGTH_BYTE_ARRAY`, right? I'm not sure if there is any use case in the wild.



##########
src/main/thrift/parquet.thrift:
##########
@@ -151,14 +151,14 @@ enum ConvertedType {
   /**
    * An embedded JSON document
    *
-   * A JSON document embedded within a single UTF8 column.
+   * A JSON document embedded within a single BYTE_ARRAY(STRING) column.

Review Comment:
   Should we keep it as is? This is the deprecated `ConvertedType` section where `UTF8` is used for string type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org