You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2026/08/03 17:55:20 UTC
[PR] Guard quiche-only QUIC connection state [trafficserver]
bneradt opened a new pull request, #13478:
URL: https://github.com/apache/trafficserver/pull/13478
Native OpenSSL QUIC builds do not use the connection table or quiche
timeout event stored by QUICNetVConnection. Clang diagnoses those
quiche-only private fields as unused, causing warnings-as-errors builds
to fail.
This guards the members with TS_HAS_QUICHE so native OpenSSL builds do
not declare them while quiche builds retain the required state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard quiche-only QUIC connection state [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13478:
URL: https://github.com/apache/trafficserver/pull/13478#issuecomment-5181035236
Cherry-picked to the 10.2.x branch as c4595b239e63d6b3af9f47aa382c74f982a2f742 for the 10.2.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard quiche-only QUIC connection state [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #13478:
URL: https://github.com/apache/trafficserver/pull/13478#discussion_r3706639858
##########
src/iocore/net/P_QUICNetVConnection.h:
##########
@@ -240,10 +242,12 @@ class QUICNetVConnection : public UnixNetVConnection,
void _close_packet_write_ready(Event *data);
Event *_packet_write_ready = nullptr;
- void _schedule_quiche_timeout();
- void _unschedule_quiche_timeout();
- void _close_quiche_timeout(Event *data);
+ void _schedule_quiche_timeout();
+ void _unschedule_quiche_timeout();
+ void _close_quiche_timeout(Event *data);
+#if TS_HAS_QUICHE
Event *_quiche_timeout = nullptr;
+#endif
Review Comment:
These are private backend hooks rather than part of a shared external interface. The OpenSSL implementation already supplies explicit no-op definitions for all three methods, while CMake selects only one of the OpenSSL or quiche implementation files. Guarding the declarations would therefore also require removing those definitions and would not address an active correctness or warning issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard quiche-only QUIC connection state [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #13478:
URL: https://github.com/apache/trafficserver/pull/13478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard quiche-only QUIC connection state [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13478:
URL: https://github.com/apache/trafficserver/pull/13478#discussion_r3706602227
##########
src/iocore/net/P_QUICNetVConnection.h:
##########
@@ -240,10 +242,12 @@ class QUICNetVConnection : public UnixNetVConnection,
void _close_packet_write_ready(Event *data);
Event *_packet_write_ready = nullptr;
- void _schedule_quiche_timeout();
- void _unschedule_quiche_timeout();
- void _close_quiche_timeout(Event *data);
+ void _schedule_quiche_timeout();
+ void _unschedule_quiche_timeout();
+ void _close_quiche_timeout(Event *data);
+#if TS_HAS_QUICHE
Event *_quiche_timeout = nullptr;
+#endif
Review Comment:
The quiche-timeout methods are unconditionally declared while the state they likely operate on (`_quiche_timeout`) is now quiche-only. To keep the class interface consistent across build modes (and prevent accidental use or future build breaks if these methods reference `_quiche_timeout` in inline code), consider guarding these method declarations with `#if TS_HAS_QUICHE` as well, or providing no-op/alternate implementations when `TS_HAS_QUICHE` is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org