You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2006/12/08 12:45:22 UTC

[jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

    [ http://issues.apache.org/jira/browse/HADOOP-808?page=comments#action_12456787 ] 
            
Hadoop QA commented on HADOOP-808:
----------------------------------

+1, http://issues.apache.org/jira/secure/attachment/12346754/myjob.tgz applied and successfully tested against trunk revision r483772

> Enhance 'bin/hadoop job -submit <>'
> -----------------------------------
>
>                 Key: HADOOP-808
>                 URL: http://issues.apache.org/jira/browse/HADOOP-808
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.9.1
>            Reporter: Arun C Murthy
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: HADOOP-808_1_20061208.patch, myjob.tgz
>
>
> Today 'bin/hadoop job -submit' takes a config file and just does a JobClient.submitJob(jobConf), this isn't flexible enough for cases where the user wants to submit a job which calls his main(), does some work and then calls 'JobClient.runJob', I propose we enhance this subcommand to handle that scenario. This could be really useful for the time we decide to setup a simple webpage with 'form' where the user uploads a job.xml & job.jar and we can fire the job.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

Posted by Nigel Daley <nd...@yahoo-inc.com>.
On Dec 8, 2006, at 1:40 PM, Doug Cutting wrote:

> Nigel Daley wrote:
>> So far I haven't had any failures.  Perhaps we should wait for  
>> more experience?  Currently, the system will email me after 2  
>> failed build/test attempts on the same patch.  I could send these  
>> failure emails to hadoop-dev if you'd prefer.  But realize that  
>> these emails may occasionally be false negatives.
>
> Ideally we'd get a '-1' comment if the patch doesn't apply to  
> trunk, no?  This would be annoying if there were lots of false  
> negatives.  But it could save folks time, when, e.g., a patch gets  
> stale, if it's noted in the patch.

Ok, I haven't seen a lot of false negatives so this should work.   
I'll post a -1 comment if the build/test fails three times or if I  
can't apply the patch.

> Should we re-run tests on patches daily, and if something that  
> previously passed now fails or vice versa, note the change in state?

Ya this would be nice, but I'm not signing up for implementing this  
right now.

Cheers,
Nige

Re: [jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

Posted by Doug Cutting <cu...@apache.org>.
Nigel Daley wrote:
> So far I haven't had any failures.  Perhaps we should wait for more 
> experience?  Currently, the system will email me after 2 failed 
> build/test attempts on the same patch.  I could send these failure 
> emails to hadoop-dev if you'd prefer.  But realize that these emails may 
> occasionally be false negatives.

Ideally we'd get a '-1' comment if the patch doesn't apply to trunk, no? 
  This would be annoying if there were lots of false negatives.  But it 
could save folks time, when, e.g., a patch gets stale, if it's noted in 
the patch.

Should we re-run tests on patches daily, and if something that 
previously passed now fails or vice versa, note the change in state?

> Perhaps there's a way of making this automation more public by running 
> it (and the associated continuous integration server) on apache hosted 
> servers?

The appropriate server for this would be lucene.zones.apache.org, a 
Solaris zone (virtual solaris box).  If you'd like to set these up 
publicly that'd be great.  Alternately, we could do something like add 
attachments to issues with the log file from the first failing unit 
test, or somesuch.

Doug

Re: [jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

Posted by Nigel Daley <nd...@yahoo-inc.com>.
On Dec 8, 2006, at 9:23 AM, Doug Cutting wrote:

> Nigel Daley wrote:
>> Disregard this +1.
>
> Thanks!  I was wondering about what happened there.
>
> BTW, the auto-testing of patches is very useful.  Thanks!  I still  
> wonder if we ought to do more when tests fail.  Thoughts?

So far I haven't had any failures.  Perhaps we should wait for more  
experience?  Currently, the system will email me after 2 failed build/ 
test attempts on the same patch.  I could send these failure emails  
to hadoop-dev if you'd prefer.  But realize that these emails may  
occasionally be false negatives.

Perhaps there's a way of making this automation more public by  
running it (and the associated continuous integration server) on  
apache hosted servers?

Cheers,
Nige


Re: [jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

Posted by Doug Cutting <cu...@apache.org>.
Nigel Daley wrote:
> Disregard this +1.

Thanks!  I was wondering about what happened there.

BTW, the auto-testing of patches is very useful.  Thanks!  I still 
wonder if we ought to do more when tests fail.  Thoughts?

Doug

Re: [jira] Commented: (HADOOP-808) Enhance 'bin/hadoop job -submit <>'

Posted by Nigel Daley <nd...@yahoo-inc.com>.
Disregard this +1.  The last file attached to this issue is not a  
patch.  I've now modified my automated process to fail if the last  
attachment doesn't apply cleanly.

> Hadoop QA commented on HADOOP-808:
> ----------------------------------
>
> +1, http://issues.apache.org/jira/secure/attachment/12346754/ 
> myjob.tgz applied and successfully tested against trunk revision  
> r483772