[jira] [Commented] (PHOENIX-6093) adding hashcode to phoenix pherf Column class

["Chinmay Kulkarni (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182167#comment-17182167 ] 

Chinmay Kulkarni commented on PHOENIX-6093:
-------------------------------------------

[~yanxinyi] There's a bunch of other fields in Column.java. Why are we only focusing on name and type? Similarly, shouldn't the equals method also check equality of all the fields? 

Another related issue with equals() is: Currently, equals() says "Equal if column name and type match" but it only checks type.

> adding hashcode to phoenix pherf Column class
> ---------------------------------------------
>
>                 Key: PHOENIX-6093
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6093
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Xinyi Yan
>            Assignee: Xinyi Yan
>            Priority: Minor
>         Attachments: PHOENIX-6093.patch
>
>
> The pherf Column class overrides equals but not hashcode. Adding hashcode so that we can fully support serial upsert in numerical data types. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)