You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by JonHerr <gi...@git.apache.org> on 2016/02/24 23:29:35 UTC
[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...
GitHub user JonHerr opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/56
CB-10690 windows: fix crash when user cancels/closes photo app
wrapped the file.moveAsync() function with a check for file and return CaptureError.CAPTURE_NO_MEDIA_FILES when file is undefiened
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonHerr/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 395be1120171b686d5dbed9e32b32c9e70087a10
Author: Jonathan Herr <jo...@hotmail.com>
Date: 2016-02-24T19:24:17Z
CB-10690 windows: fix crash when user cancels/closes photo app
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/56#issuecomment-188543877
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org