[GitHub] [libcloud] Kami commented on a change in pull request #1328: powerdns driver adapted to work with pdns 3 and 4

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1328: powerdns driver adapted to work with pdns 3 and 4
URL: https://github.com/apache/libcloud/pull/1328#discussion_r310354606
 
 

 ##########
 File path: libcloud/dns/drivers/powerdns.py
 ##########
 @@ -143,7 +144,7 @@ def __init__(self, key, secret=None, secure=False, host=None, port=None,
                                              host=host, port=port,
                                              **kwargs)
 
-    def create_record(self, name, zone, type, data, extra=None):
+    def create_record(self, name, zone, type, data, extra=None, disabled=False, comment=None):
 
 Review comment:
   Those are extension arguments (arguments which are not supported by all the providers), please prefix them with ``ex_``.
   
   So ``ex_disabled`` and ``ex_comment``.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services