[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10605: [enhancement](nereids) make filter node and join node work in Nereids

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #10605:
URL: https://github.com/apache/doris/pull/10605#discussion_r913579203


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -62,8 +63,23 @@ public class ExpressionTranslator extends DefaultExpressionVisitor<Expr, PlanTra
 
     public static ExpressionTranslator INSTANCE = new ExpressionTranslator();
 
-    public static Expr translate(Expression expression, PlanTranslatorContext planContext) {
-        return expression.accept(INSTANCE, planContext);
+    /**
+     * The entry function of ExpressionTranslator, call {@link Expr#finalizeForNereids()} to generate
+     * some attributes using in BE.
+     *
+     * @param expression nereids expression
+     * @param context translator context
+     * @return stale planner's expr
+     */
+    public static Expr translate(Expression expression, PlanTranslatorContext context) {
+        Expr staleExpr =  expression.accept(INSTANCE, context);
+        try {
+            staleExpr.finalizeForNereids();

Review Comment:
   ```suggestion
               staleExpr.analyzeForNereidsExpr();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org