You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by tb...@apache.org on 2017/10/13 14:00:48 UTC
[1/3] brooklyn-library git commit: Fix use of deprecated code
Repository: brooklyn-library
Updated Branches:
refs/heads/master bd17aea7f -> 185ed9fe6
Fix use of deprecated code
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/50331ca8
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/50331ca8
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/50331ca8
Branch: refs/heads/master
Commit: 50331ca8395ad6a3a1748b15336720e61b925158
Parents: bd17aea
Author: Aled Sage <al...@gmail.com>
Authored: Tue Oct 10 09:04:11 2017 +0100
Committer: Aled Sage <al...@gmail.com>
Committed: Tue Oct 10 09:04:11 2017 +0100
----------------------------------------------------------------------
.../org/apache/brooklyn/entity/chef/ChefAttributeFeed.java | 6 +++---
.../brooklyn/entity/chef/ChefLifecycleEffectorTasks.java | 1 -
.../java/org/apache/brooklyn/entity/chef/ChefServerTasks.java | 2 +-
.../org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java | 4 ++--
4 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/50331ca8/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefAttributeFeed.java
----------------------------------------------------------------------
diff --git a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefAttributeFeed.java b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefAttributeFeed.java
index f6d2615..91c9b09 100644
--- a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefAttributeFeed.java
+++ b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefAttributeFeed.java
@@ -194,8 +194,8 @@ public class ChefAttributeFeed extends AbstractFeed {
}
protected ChefAttributeFeed(Builder builder) {
- setConfig(ONLY_IF_SERVICE_UP, builder.onlyIfServiceUp);
- setConfig(NODE_NAME, checkNotNull(builder.nodeName, "builder.nodeName"));
+ config().set(ONLY_IF_SERVICE_UP, builder.onlyIfServiceUp);
+ config().set(NODE_NAME, checkNotNull(builder.nodeName, "builder.nodeName"));
Set<ChefAttributePollConfig<?>> polls = Sets.newLinkedHashSet();
for (ChefAttributePollConfig<?> config : builder.polls) {
@@ -205,7 +205,7 @@ public class ChefAttributeFeed extends AbstractFeed {
if (configCopy.getPeriod() < 0) configCopy.period(builder.period);
polls.add(configCopy);
}
- setConfig(POLLS, polls);
+ config().set(POLLS, polls);
initUniqueTag(builder.uniqueTag, polls);
}
http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/50331ca8/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefLifecycleEffectorTasks.java
----------------------------------------------------------------------
diff --git a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefLifecycleEffectorTasks.java b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefLifecycleEffectorTasks.java
index 8c3dad9..a142de4 100644
--- a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefLifecycleEffectorTasks.java
+++ b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefLifecycleEffectorTasks.java
@@ -20,7 +20,6 @@ package org.apache.brooklyn.entity.chef;
import java.util.Collection;
import java.util.Map;
-import java.util.concurrent.atomic.AtomicReference;
import org.apache.brooklyn.api.entity.Entity;
import org.apache.brooklyn.api.location.MachineLocation;
http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/50331ca8/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefServerTasks.java
----------------------------------------------------------------------
diff --git a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefServerTasks.java b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefServerTasks.java
index c81ff9d..af0c813 100644
--- a/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefServerTasks.java
+++ b/software/cm/chef/src/main/java/org/apache/brooklyn/entity/chef/ChefServerTasks.java
@@ -51,7 +51,7 @@ public class ChefServerTasks {
if (data==null) return null;
try {
f.deleteOnExit();
- Files.write(SecureKeys.stringPem(data), f, Charset.defaultCharset());
+ Files.write(SecureKeys.toPem(data), f, Charset.defaultCharset());
return f;
} catch (IOException e) {
throw Throwables.propagate(e);
http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/50331ca8/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java
----------------------------------------------------------------------
diff --git a/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java b/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java
index 222891e..b8366a9 100644
--- a/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java
+++ b/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxSshDriver.java
@@ -118,10 +118,10 @@ public class NginxSshDriver extends AbstractSoftwareProcessSshDriver implements
entity.sensors().set(NginxController.PID_FILE, getRunDir() + "/" + AbstractSoftwareProcessSshDriver.PID_FILENAME);
if (((AbstractController)entity).isSsl()) {
entity.sensors().set(Attributes.HTTPS_PORT, getPort());
- ((EntityInternal)entity).removeAttribute(Attributes.HTTP_PORT);
+ ((EntityInternal)entity).sensors().remove(Attributes.HTTP_PORT);
} else {
entity.sensors().set(Attributes.HTTP_PORT, getPort());
- ((EntityInternal)entity).removeAttribute(Attributes.HTTPS_PORT);
+ ((EntityInternal)entity).sensors().remove(Attributes.HTTPS_PORT);
}
super.postLaunch();
}
[3/3] brooklyn-library git commit: This closes #135
Posted by tb...@apache.org.
This closes #135
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/185ed9fe
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/185ed9fe
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/185ed9fe
Branch: refs/heads/master
Commit: 185ed9fe666d7de1fddbb7a41c840d2e04c5699b
Parents: bd17aea 03b414c
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Authored: Fri Oct 13 14:59:21 2017 +0100
Committer: Thomas Bouron <th...@cloudsoftcorp.com>
Committed: Fri Oct 13 14:59:21 2017 +0100
----------------------------------------------------------------------
.../brooklyn/entity/chef/ChefAttributeFeed.java | 6 ++--
.../entity/chef/ChefLifecycleEffectorTasks.java | 1 -
.../brooklyn/entity/chef/ChefServerTasks.java | 2 +-
.../storm/StormAbstractCloudLiveTest.java | 29 +++++++-------------
.../entity/proxy/nginx/NginxSshDriver.java | 4 +--
5 files changed, 16 insertions(+), 26 deletions(-)
----------------------------------------------------------------------
[2/3] brooklyn-library git commit: Fix storm live test setup/teardown
Posted by tb...@apache.org.
Fix storm live test setup/teardown
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/03b414c4
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/03b414c4
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/03b414c4
Branch: refs/heads/master
Commit: 03b414c4b449713a33334c0a57ee98b35c2d2567
Parents: 50331ca
Author: Aled Sage <al...@gmail.com>
Authored: Tue Oct 10 09:04:20 2017 +0100
Committer: Aled Sage <al...@gmail.com>
Committed: Tue Oct 10 09:04:20 2017 +0100
----------------------------------------------------------------------
.../storm/StormAbstractCloudLiveTest.java | 29 +++++++-------------
1 file changed, 10 insertions(+), 19 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/03b414c4/software/messaging/src/test/java/org/apache/brooklyn/entity/messaging/storm/StormAbstractCloudLiveTest.java
----------------------------------------------------------------------
diff --git a/software/messaging/src/test/java/org/apache/brooklyn/entity/messaging/storm/StormAbstractCloudLiveTest.java b/software/messaging/src/test/java/org/apache/brooklyn/entity/messaging/storm/StormAbstractCloudLiveTest.java
index 9fa27bf..e712791 100644
--- a/software/messaging/src/test/java/org/apache/brooklyn/entity/messaging/storm/StormAbstractCloudLiveTest.java
+++ b/software/messaging/src/test/java/org/apache/brooklyn/entity/messaging/storm/StormAbstractCloudLiveTest.java
@@ -34,8 +34,9 @@ import org.apache.brooklyn.core.entity.Attributes;
import org.apache.brooklyn.core.entity.Entities;
import org.apache.brooklyn.core.entity.EntityAsserts;
import org.apache.brooklyn.core.entity.trait.Startable;
-import org.apache.brooklyn.core.mgmt.internal.LocalManagementContext;
import org.apache.brooklyn.core.test.BrooklynAppLiveTestSupport;
+import org.apache.brooklyn.entity.messaging.storm.topologies.ExclamationBolt;
+import org.apache.brooklyn.entity.zookeeper.ZooKeeperEnsemble;
import org.apache.brooklyn.util.collections.MutableMap;
import org.apache.brooklyn.util.core.ResourceUtils;
import org.apache.brooklyn.util.core.file.ArchiveBuilder;
@@ -45,10 +46,12 @@ import org.apache.brooklyn.util.time.Time;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.testng.Assert;
-import org.testng.annotations.AfterClass;
-import org.testng.annotations.BeforeClass;
+import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
+import com.google.common.base.Throwables;
+import com.google.common.collect.ImmutableList;
+
import backtype.storm.Config;
import backtype.storm.StormSubmitter;
import backtype.storm.generated.AlreadyAliveException;
@@ -57,12 +60,6 @@ import backtype.storm.generated.StormTopology;
import backtype.storm.testing.TestWordSpout;
import backtype.storm.topology.TopologyBuilder;
-import org.apache.brooklyn.entity.messaging.storm.topologies.ExclamationBolt;
-import org.apache.brooklyn.entity.zookeeper.ZooKeeperEnsemble;
-
-import com.google.common.base.Throwables;
-import com.google.common.collect.ImmutableList;
-
public abstract class StormAbstractCloudLiveTest extends BrooklynAppLiveTestSupport {
protected static final Logger log = LoggerFactory
@@ -73,17 +70,11 @@ public abstract class StormAbstractCloudLiveTest extends BrooklynAppLiveTestSupp
private Storm supervisor;
private Storm ui;
- @BeforeClass(alwaysRun = true)
- public void beforeClass() throws Exception {
- mgmt = new LocalManagementContext();
- location = mgmt.getLocationRegistry()
- .getLocationManaged(getLocation(), getFlags());
+ @BeforeMethod(alwaysRun = true)
+ @Override
+ public void setUp() throws Exception {
super.setUp();
- }
-
- @AfterClass(alwaysRun = true)
- public void afterClass() throws Exception {
- // Entities.destroyAll(mgmt);
+ location = mgmt.getLocationRegistry().getLocationManaged(getLocation(), getFlags());
}
public abstract String getLocation();