You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/10 04:44:53 UTC

[GitHub] [apisix] Yiyiyimu opened a new pull request #2205: doc: add option `include_req_body`

Yiyiyimu opened a new pull request #2205:
URL: https://github.com/apache/apisix/pull/2205


   ### What this PR does / why we need it:
   fix #2195 
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2205: doc: add option `include_req_body`

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2205:
URL: https://github.com/apache/apisix/pull/2205#discussion_r486104143



##########
File path: doc/zh-cn/plugins/http-logger.md
##########
@@ -46,6 +46,7 @@
 | buffer_duration |可选的|必须先处理批次中最旧条目的最长期限（以秒为单位），默认值为 5|
 | max_retry_count |可选的|从处理管道中移除之前的最大重试次数，默认为 0|
 | retry_delay |可选的|如果执行失败，则应延迟执行流程的秒数，默认为 1|
+|include_req_body|可选的| 返回请求 body，默认为 false|

Review comment:
       take a look at: https://github.com/apache/apisix/pull/2205#discussion_r486103749




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2205: doc: add option `include_req_body`

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2205:
URL: https://github.com/apache/apisix/pull/2205#discussion_r486103749



##########
File path: doc/plugins/syslog.md
##########
@@ -47,6 +47,7 @@ This will provide the ability to send Log data requests as JSON objects.
 |max_retry_times|optional       |Max number of retry times after a connect to a log server failed or send log messages to a log server failed.|
 |retry_interval|optional       |The time delay (in ms) before retry to connect to a log server or retry to send log messages to a log server, default to 100 (0.1s).|
 |pool_size    |optional       |Keepalive pool size used by sock:keepalive. Default to 10.|
+|include_req_body|optional      |Return request body besides head; default is false|

Review comment:
       "Return request body besides head;"
   ->
   "Whether to include the request body, the default is false, which means it is not included."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming closed pull request #2205: doc: add option `include_req_body`

Posted by GitBox <gi...@apache.org>.
moonming closed pull request #2205:
URL: https://github.com/apache/apisix/pull/2205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #2205: doc: add option `include_req_body`

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #2205:
URL: https://github.com/apache/apisix/pull/2205#issuecomment-689978415


   Chinese doc of plugins format needs to be unified。


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming closed pull request #2205: doc: add option `include_req_body`

Posted by GitBox <gi...@apache.org>.
moonming closed pull request #2205:
URL: https://github.com/apache/apisix/pull/2205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org