You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/07/26 17:26:41 UTC

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/4404

    [FLINK-4565] [table] Support for SQL IN operator

    ## What is the purpose of the change
    
    *This PR adds support for the IN operator in both SQL and Table API. Both for testing in a set of elements `f0.in(1, 2, 3)` as well as in sub-query `f0.in(table)`*
    
    
    ## Brief change log
    
    *Various changes in plan translation, code generation, and API.*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Unit tests: org.apache.flink.table.expressions.ScalarOperatorsTest*
      - *Unit tests: org.apache.flink.table.expressions.validation.ScalarOperatorsValidationTest*
      - *Integration tests: org.apache.flink.table.runtime.batch.sql.SetOperatorsITCase*
      - *Integration tests: org.apache.flink.table.runtime.batch.table.SetOperatorsITCase*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? not documented
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4565

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4404
    
----
commit c0e7f58973cd4237382811b7ae1ee4fb4cdcaebf
Author: DmytroShkvyra <ds...@gmail.com>
Date:   2017-03-09T19:37:46Z

    [FLINK-4565] [table] Support for SQL IN operator

commit 14ff3c23e04c03c018118cc8ab33ea7255277ef9
Author: twalthr <tw...@apache.org>
Date:   2017-07-26T16:11:38Z

    [FLINK-4565] [table] Full IN operator support for literals and sub-queries

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

Posted by tedyu <gi...@git.apache.org>.

Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4404#discussion_r131654308
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala ---
    @@ -0,0 +1,95 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.expressions
    +
    +import com.google.common.collect.ImmutableList
    +import org.apache.calcite.rex.{RexNode, RexSubQuery}
    +import org.apache.calcite.sql.fun.SqlStdOperatorTable
    +import org.apache.calcite.tools.RelBuilder
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo._
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.table.api.StreamTableEnvironment
    +import org.apache.flink.table.typeutils.TypeCheckUtils._
    +import org.apache.flink.table.validate.{ValidationFailure, ValidationResult, ValidationSuccess}
    +
    +case class In(expression: Expression, elements: Seq[Expression]) extends Expression  {
    +
    +  override def toString = s"$expression.in(${elements.mkString(", ")})"
    +
    +  override private[flink] def children: Seq[Expression] = expression +: elements.distinct
    +
    +  override private[flink] def toRexNode(implicit relBuilder: RelBuilder): RexNode = {
    +    // check if this is a sub-query expression or an element list
    +    elements.head match {
    +
    +      case TableReference(name, table) =>
    +        RexSubQuery.in(table.getRelNode, ImmutableList.of(expression.toRexNode))
    +
    +      case _ =>
    +        relBuilder.call(SqlStdOperatorTable.IN, children.map(_.toRexNode): _*)
    +    }
    +  }
    +
    +  override private[flink] def validateInput(): ValidationResult = {
    +    // check if this is a sub-query expression or an element list
    +    elements.head match {
    +
    +      case TableReference(name, table) =>
    +        if (elements.length != 1) {
    +          return ValidationFailure("IN operator supports only one table reference.")
    +        }
    +        if (table.tableEnv.isInstanceOf[StreamTableEnvironment]) {
    +          return ValidationFailure(
    +            "Sub-query IN operator on stream tables is currently not supported.")
    +        }
    +        val tableOutput = table.logicalPlan.output
    +        if (tableOutput.length > 1) {
    +          return ValidationFailure(
    +            s"The sub-query table '$name' must not have more than one column.")
    +        }
    +        (expression.resultType, tableOutput.head.resultType) match {
    +          case (lType, rType) if isNumeric(lType) && isNumeric(rType) => ValidationSuccess
    +          case (lType, rType) if lType == rType => ValidationSuccess
    --- End diff --
    
    Should I open a new JIRA ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---