You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/07 01:48:45 UTC

[GitHub] [iotdb] cigarl commented on a diff in pull request #5807: [IOTDB-3097] PartitionInfo snapshot interface

cigarl commented on code in PR #5807:
URL: https://github.com/apache/iotdb/pull/5807#discussion_r867286398


##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/PartitionInfo.java:
##########
@@ -298,15 +310,114 @@ public List<TRegionReplicaSet> getRegionReplicaSets(List<TConsensusGroupId> grou
     return result;
   }
 
-  public void serialize(ByteBuffer buffer) {
-    // TODO: Serialize PartitionInfo
+  public boolean takeSnapshot(File snapshotFile) throws TException, IOException {
+
+    File tmpFile = new File(snapshotFile.getAbsolutePath() + "-" + UUID.randomUUID());

Review Comment:
   FileName is controlled by executor，see [#5816](https://github.com/apache/iotdb/pull/5816)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org