You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/06 23:24:04 UTC
[GitHub] [beam] robertwb commented on a diff in pull request #17482: [BEAM-14374] Fix module import error in FullyQualifiedNamedTransform
robertwb commented on code in PR #17482:
URL: https://github.com/apache/beam/pull/17482#discussion_r867263904
##########
sdks/python/apache_beam/transforms/fully_qualified_named_transform_test.py:
##########
@@ -116,6 +119,14 @@ def test_glob_filter(self):
with self.assertRaises(ValueError):
FullyQualifiedNamedTransform._resolve('apache_beam.Row')
+ @patch('importlib.import_module')
+ def test_resolve(self, mock_import_module):
Review Comment:
Sorry to be a stickler, but this mocking doesn't actually convince me that the code in question actually does the right thing. Could you actually perform an import here so that we know we're interacting with the import module in the right way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org